Nimbus jose jwt library upgrade due to vulnerabilities #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -113,7 +113,7 @@ dependencies { | |||
| implementation group: 'org.json', name: 'json', version: '20190722' | |||
|
|
|||
| //https://mvnrepository.com/artifact/com.nimbusds/nimbus-jose-jwt | |||
| implementation group: 'com.nimbusds', name: 'nimbus-jose-jwt', version: '8.3' | |||
| implementation group: 'com.nimbusds', name: 'nimbus-jose-jwt', version: '9.12' | |||
There was a problem hiding this comment.
@SampathKumarAmex this should not break our existing vulnerable levels. Can you please check vulnerable level using this library and see if that is working as expected
There was a problem hiding this comment.
Could you please provide more info on how to test that? Do you have any documentation covering that part?
It's good to have some test for this if feasible.
There was a problem hiding this comment.
@SampathKumarAmex we need to start VulnerableApp, go to UI, and test that each level doesn't break.
There was a problem hiding this comment.
yeah, we are lacking unit tests and other things right now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://mvnrepository.com/artifact/com.nimbusds/nimbus-jose-jwt/8.3
GHSA-g5vf-v6wf-7w2r
GHSA-269g-pwp5-87pp