#335 Removing deprecated fields #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -298,23 +286,20 @@ public JWTVulnerability(IJWTTokenGenerator libBasedJWTGenerator, IJWTValidator j | |||
| vulnerabilityExposed = VulnerabilityType.CLIENT_SIDE_VULNERABLE_JWT, | |||
| description = "COOKIE_WITH_HTTPONLY_WITHOUT_SECURE_FLAG_BASED_JWT_VULNERABILITY") | |||
| @AttackVector( | |||
| vulnerabilityExposed = {VulnerabilityType.SERVER_SIDE_VULNERABLE_JWT}, | |||
| description = "COOKIE_BASED_NULL_BYTE_JWT_VULNERABILITY") | |||
| vulnerabilityExposed = VulnerabilityType.INSECURE_CONFIGURATION_JWT, | |||
There was a problem hiding this comment.
@Monoradioactivo can you please fix the ordering of the methods?
There was a problem hiding this comment.
Level4 and Level5 are i think swapped.
preetkaran20
requested changes
Oct 16, 2021
There was a problem hiding this comment.
Thanks for the PR. Overall, it looks good to me.
- Please remove all these label keys from messages.properties and messages_en_us.properties files in src/main/resource/i18n
- Please rebase the changes as they are having changes from previous commit.
- Please comment on the github issue linked with this PR, that you are working on it.
| @@ -0,0 +1,16 @@ | |||
| #SampleVulnerability { | |||
There was a problem hiding this comment.
these changes are from previous commit.
|
Hi @Monoradioactivo , Can you please run: Run './gradlew spotlessApply' and push the commit again for fixing indentation failure Thanks, |
Done |
|
Hi @Monoradioactivo , Thanks a lot for the PR. Merging it. thanks, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.