Add cancellation support to cache cleanup task - #29
Merged
Conversation
The background cleanup task used while(true) with no way to stop it during application shutdown. Now uses CancellationTokenSource that gets cancelled on Dispose(), allowing graceful shutdown. Closes #26
Sarmkadan
commented
May 21, 2026
Sarmkadan
left a comment
Sarmkadan
left a comment
Owner
Author
There was a problem hiding this comment.
Clean fix. The only thing I'd add for completeness is making sure the DI container is configured to treat this as a singleton so Dispose gets called at the right time. But that's a configuration concern, not a code issue.
Sarmkadan
added a commit
that referenced
this pull request
Jul 11, 2026
The background cleanup task used while(true) with no way to stop it during application shutdown. Now uses CancellationTokenSource that gets cancelled on Dispose(), allowing graceful shutdown. Closes #26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
InMemoryCacheServicebackground cleanup task ran in an infinite loop with no cancellation support, preventing graceful shutdown.Changes
InMemoryCacheServicenow implementsIDisposableCancellationTokenSourcethat's passed to the cleanup taskIsCancellationRequestedand theTask.Delaycall honors the tokenOperationCanceledExceptionis caught and handled cleanly during shutdownTesting
Dispose()is calledCloses #26