Conversation
…and observer cleanup
…-deps, and update docs
…check to satisfy Ruff TRY300
…ifespan, and move asyncio import to stdlib group
…ion logging feedback
…nd update UI/README
….py fallbacks, and unused vars
…null-safe, logging)
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
📝 Walkthrough워크스루GitHub Actions 워크플로우의 Supabase keep-alive 핑 로직이 수정되었습니다. curl 요청이 HEAD 방식에서 GET 방식으로 변경되었고, 엔드포인트가 루트에서 변경 사항
추정 코드 리뷰 노력🎯 2 (Simple) | ⏱️ ~10분 관련될 가능성이 있는 PR
시
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.github/workflows/keep-alive.yml (1)
24-24: 하드코딩된 Supabase URL 유지보수 문제
backend/app/services/database.py에서 백엔드는settings.SUPABASE_URL환경 변수를 통해 Supabase URL을 동적으로 설정하고 있습니다. 하지만 이 워크플로우에서는 URL이 하드코딩되어 있어, 환경 변수가 변경되면 이 워크플로우는 잘못된 엔드포인트를 ping하게 됩니다.GitHub Secrets를 사용하여 URL을 관리하는 것을 권장합니다.
♻️ GitHub Secrets 사용 제안
URLS=( "https://philo-rag-backend.onrender.com/health" - "https://jjadfpnpfuxjbmkxyhqt.supabase.co/rest/v1/" + "${{ secrets.SUPABASE_URL }}/rest/v1/" )🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/keep-alive.yml at line 24, The workflow currently hardcodes the Supabase URL string ("https://jjadfpnpfuxjbmkxyhqt.supabase.co/rest/v1/") which will drift from the backend's settings.SUPABASE_URL; update the keep-alive workflow to read the URL from a GitHub Actions secret (e.g., secrets.SUPABASE_URL) and use that secret value wherever the hardcoded string is used so the ping target stays in sync with backend/app/services/database.py's configuration.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In @.github/workflows/keep-alive.yml:
- Line 24: The workflow currently hardcodes the Supabase URL string
("https://jjadfpnpfuxjbmkxyhqt.supabase.co/rest/v1/") which will drift from the
backend's settings.SUPABASE_URL; update the keep-alive workflow to read the URL
from a GitHub Actions secret (e.g., secrets.SUPABASE_URL) and use that secret
value wherever the hardcoded string is used so the ping target stays in sync
with backend/app/services/database.py's configuration.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: e0da79a1-0048-48d5-8033-3d7089c46258
📒 Files selected for processing (1)
.github/workflows/keep-alive.yml
Summary by CodeRabbit