Skip to content

Feat/add keep alive action#25

Merged
SanghunYun95 merged 64 commits intomainfrom
feat/add-keep-alive-action
Mar 25, 2026
Merged

Feat/add keep alive action#25
SanghunYun95 merged 64 commits intomainfrom
feat/add-keep-alive-action

Conversation

@SanghunYun95
Copy link
Copy Markdown
Owner

@SanghunYun95 SanghunYun95 commented Mar 25, 2026

Summary by CodeRabbit

  • Chores
    • 서비스 가용성 모니터링 로직 개선으로 더욱 안정적인 상태 유지

…ifespan, and move asyncio import to stdlib group
@vercel
Copy link
Copy Markdown

vercel bot commented Mar 25, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
philo-rag Ready Ready Preview, Comment Mar 25, 2026 1:43pm

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 25, 2026

📝 Walkthrough

워크스루

GitHub Actions 워크플로우의 Supabase keep-alive 핑 로직이 수정되었습니다. curl 요청이 HEAD 방식에서 GET 방식으로 변경되었고, 엔드포인트가 루트에서 /rest/v1/로 변경되었습니다. HTTP 상태 코드 처리 로직이 추가되어 000 또는 500 이상의 상태를 오류로, 2xx–4xx 범위를 성공으로 처리합니다.

변경 사항

코호트 / 파일 요약
Supabase Keep-Alive 워크플로우
.github/workflows/keep-alive.yml
curl 요청을 HEAD에서 GET으로 변경하고, 엔드포인트를 /rest/v1/로 업데이트. HTTP 상태 코드 검증 로직을 추가하여 연결 실패(000), 서버 오류(>=500)를 감지하고 2xx–4xx 범위를 수락.

추정 코드 리뷰 노력

🎯 2 (Simple) | ⏱️ ~10분

관련될 가능성이 있는 PR

  • Feat/add keep alive action #24: 동일한 .github/workflows/keep-alive.yml 파일의 curl 호출(GET으로 변경, HTTP_CODE 캡처, 상태 코드 처리)과 URL 엔드포인트(/rest/v1/)를 동일하게 수정하고 있습니다.
  • Feat/add keep alive action #22: keep-alive 핑 로직(curl 호출 및 대상 URL)의 동일한 GitHub Actions 워크플로우를 수정하고 있습니다.

🐰 Supabase의 맥박을 재며,
GET 방식으로 살그머니 살핀다,
상태 코드로 오류를 가려내고,
500의 벽을 넘지 않으면,
서비스는 쾌활하게 살아간다! 💚✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed 제목이 keep-alive 액션 추가라는 실제 변경사항을 반영하고 있으나, 구체적인 세부 사항이 부족하다.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/add-keep-alive-action

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
.github/workflows/keep-alive.yml (1)

24-24: 하드코딩된 Supabase URL 유지보수 문제

backend/app/services/database.py에서 백엔드는 settings.SUPABASE_URL 환경 변수를 통해 Supabase URL을 동적으로 설정하고 있습니다. 하지만 이 워크플로우에서는 URL이 하드코딩되어 있어, 환경 변수가 변경되면 이 워크플로우는 잘못된 엔드포인트를 ping하게 됩니다.

GitHub Secrets를 사용하여 URL을 관리하는 것을 권장합니다.

♻️ GitHub Secrets 사용 제안
          URLS=(
            "https://philo-rag-backend.onrender.com/health"
-           "https://jjadfpnpfuxjbmkxyhqt.supabase.co/rest/v1/"
+           "${{ secrets.SUPABASE_URL }}/rest/v1/"
          )
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In @.github/workflows/keep-alive.yml at line 24, The workflow currently
hardcodes the Supabase URL string
("https://jjadfpnpfuxjbmkxyhqt.supabase.co/rest/v1/") which will drift from the
backend's settings.SUPABASE_URL; update the keep-alive workflow to read the URL
from a GitHub Actions secret (e.g., secrets.SUPABASE_URL) and use that secret
value wherever the hardcoded string is used so the ping target stays in sync
with backend/app/services/database.py's configuration.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In @.github/workflows/keep-alive.yml:
- Line 24: The workflow currently hardcodes the Supabase URL string
("https://jjadfpnpfuxjbmkxyhqt.supabase.co/rest/v1/") which will drift from the
backend's settings.SUPABASE_URL; update the keep-alive workflow to read the URL
from a GitHub Actions secret (e.g., secrets.SUPABASE_URL) and use that secret
value wherever the hardcoded string is used so the ping target stays in sync
with backend/app/services/database.py's configuration.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: e0da79a1-0048-48d5-8033-3d7089c46258

📥 Commits

Reviewing files that changed from the base of the PR and between 5dd6710 and 1ff42a1.

📒 Files selected for processing (1)
  • .github/workflows/keep-alive.yml

@SanghunYun95 SanghunYun95 merged commit be7dc7a into main Mar 25, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant