-
Notifications
You must be signed in to change notification settings - Fork 0
Feat/book metadata #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
44 commits
Select commit
Hold shift + click to select a range
5a5407a
feat: integrate korean book metadata and UI citations
SanghunYun95 8a01e1d
fix: apply coderabbit review suggestions
SanghunYun95 133442a
fix(backend): apply coderabbit review feedback for db and mapping scr…
SanghunYun95 43d1722
fix(backend): address additional coderabbit PR inline comments
SanghunYun95 0dd84a4
refactor(backend): use shared env parser and HTTPS for API
SanghunYun95 3057ad7
fix(backend): allow key rotation for all errors in book mapping
SanghunYun95 fc24774
feat: implement dynamic chat title and dynamic philosopher highlighting
SanghunYun95 cdbc817
fix: apply CodeRabbit PR review feedback
SanghunYun95 6c7566d
fix(pr): address CodeRabbit review feedback on backend tools and DB s…
SanghunYun95 78fc51a
chore: resolve merge conflicts
SanghunYun95 9de894d
fix(pr): address additional CodeRabbit comments
SanghunYun95 3d773d7
style: update welcome messages and input placeholder to be more gener…
SanghunYun95 4335bee
fix(pr): address additional CodeRabbit feedback for title truncation …
SanghunYun95 7298aac
UI: Remove redundant buttons (useful, copy, regenerate) from MessageList
SanghunYun95 30dd215
Merge branch 'main' into feat/book-metadata
SanghunYun95 ce91d6a
Refactor: apply CodeRabbit review suggestions
SanghunYun95 0bd1fcd
docs: rewrite README for interviewers
SanghunYun95 1196e30
docs, refactor: refine README and MessageList observer logic per PR c…
SanghunYun95 1b31b83
refactor: resolve observer unmount leak, Biome formatting, exhaustive…
SanghunYun95 e1ec3fc
fix: clear visibleMessages on unmount & use targeted eslint disable
SanghunYun95 36bd572
docs, refactor: disable philosopher filtering & update README examples
SanghunYun95 f13f327
refactor: apply PR refinements for mapping script and observers
SanghunYun95 1a9358b
Merge origin/main into feat/book-metadata (Resolve conflicts)
SanghunYun95 5d2841d
Fix: apply CodeRabbit feedback for React hooks and Tailwind
SanghunYun95 2584e3b
Feat: support multiple GEMINI_API_KEYS via comma-separated env var fo…
SanghunYun95 2395400
Fix: apply PR CodeRabbit round 8 feedback and add favicon
SanghunYun95 a0f719c
Fix: resolve conflicts and apply PR CodeRabbit round 9 feedback
SanghunYun95 789bdf4
Fix: apply PR CodeRabbit round 10 feedback
SanghunYun95 4c33094
Fix: apply PR CodeRabbit round 11 feedback
SanghunYun95 c9b0b91
Fix: apply PR CodeRabbit round 12 feedback
SanghunYun95 f24b224
fix(backend): preload models on startup and use async invokes to prev…
SanghunYun95 622a663
test: update mocks for refactored async llm/embedding functions
SanghunYun95 9eedd78
fix(pr): address lint, magic numbers, and use favicon for logo
SanghunYun95 4d878c2
fix(pr): resolve conflicts and add sizes prop to next/image
SanghunYun95 8495460
fix(backend): load models in background to prevent startup timeout on…
SanghunYun95 110049b
fix(backend): resolve conflict and apply PR feedback (timeouts, track…
SanghunYun95 105a59c
fix(backend): add graceful teardown for preload task on shutdown
SanghunYun95 7d918eb
feat(backend): add /ready endpoint and handle CancelledError in preload
SanghunYun95 382f90e
fix(backend): handle CancelledError properly in /ready readiness probe
SanghunYun95 1987897
fix(backend): lazy load ML models in chat routes to avoid Uvicorn sta…
SanghunYun95 f11491c
fix(backend): add error logging to /ready endpoint for better observa…
SanghunYun95 cad791b
refactor(backend): use else block for successful return in readiness …
SanghunYun95 e94fbe2
refactor(backend): use logger.warning in /ready, catch Exception in l…
SanghunYun95 359511c
Merge branch 'main' into feat/book-metadata and apply lifespan except…
SanghunYun95 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
사용하지 않는 예외 변수
e를 제거해주세요.Line 52에서
e를 바인딩하지만 사용하지 않아 불필요한 lint 경고(F841)가 발생합니다.🔧 제안 수정
📝 Committable suggestion
🧰 Tools
🪛 Ruff (0.15.2)
[error] 52-52: Local variable
eis assigned to but never usedRemove assignment to unused variable
e(F841)
🤖 Prompt for AI Agents