Skip to content

Make build more robust#19

Merged
Strivin0311 merged 2 commits intoSandAI-org:mainfrom
julian-q:patch-1
May 6, 2025
Merged

Make build more robust#19
Strivin0311 merged 2 commits intoSandAI-org:mainfrom
julian-q:patch-1

Conversation

@julian-q
Copy link
Copy Markdown
Contributor

@julian-q julian-q commented May 1, 2025

This PR duplicates Dao-AILab/flash-attention#1598 from the Flash Attention repo.

In certain environments the relative path to the vendored nvcc is not picked up correctly if provided relative. In this PR, I just make it absolute.

It would be helpful to include here for ease of building :)

Copy link
Copy Markdown
Contributor

@Strivin0311 Strivin0311 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Strivin0311
Copy link
Copy Markdown
Contributor

but please use pre-commit to polish the code, w.r.t. CONTRIBUTING.md.

@Strivin0311
Copy link
Copy Markdown
Contributor

thanks again!

Copy link
Copy Markdown
Contributor

@Strivin0311 Strivin0311 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Strivin0311 Strivin0311 merged commit 1ec7f7f into SandAI-org:main May 6, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants