Create Median Imputation feature #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
fredabisai
commented
Nov 20, 2023
fredabisai
commented
- Create Median Imputation feature
- Write Unit Test for Median Imputation
Samyssmile
requested changes
Nov 20, 2023
| for (String value : datasetColumn) { | ||
| if (!isNumeric(value)) { | ||
| throw new RuntimeException( | ||
| "AVERAGE imputation strategy can not be used on categorical features. " |
| } | ||
| } | ||
|
|
||
| private boolean isNumeric(String value) { |
There was a problem hiding this comment.
What about value.isBlank(), why is a blank String numeric. I dont say this is wrong, just want to understand.
| return value.matches("-?\\d+(\\.\\d+)?") || value.isBlank(); | ||
| } | ||
|
|
||
| private double calculateMedian(String[] datasetColumn) { |
|
|
||
| private double calculateMedian(String[] datasetColumn) { | ||
| List<String> filteredDatasetColumn = | ||
| Arrays.stream(datasetColumn).filter((value) -> !value.isBlank()).toList(); |
There was a problem hiding this comment.
The method utilizes two separate streams - one for filtering non-blank values and another for converting to Double objects. This approach increases overhead due to the creation of multiple streams and lists.
You use List of Doubles, this is much less efficient compared double[] here. So pls use an array and instead of Collections.sort use Arrays.sort(numbers); this will outperform Collections.sort by far.
| List<String> filteredDatasetColumn = | ||
| Arrays.stream(datasetColumn).filter((value) -> !value.isBlank()).toList(); | ||
| List<Double> filteredDatasetColumnInNumbers = | ||
| new java.util.ArrayList<>(filteredDatasetColumn.stream().map(Double::parseDouble).toList()); |
There was a problem hiding this comment.
Do not use static import here.
Samyssmile
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.