Fixes and CLANG static analyzer fixes #23
Conversation
…by nullptrs or potential memory leakage in Obj-C. These were provided by Clang's Static Analyzer, and fixes by myself.
There was a problem hiding this comment.
Fixes a non-released coreFoundation object
There was a problem hiding this comment.
Fixes a retain object issue.
There was a problem hiding this comment.
This can be ignored/deleted
There was a problem hiding this comment.
Fixes a buffer overflow issue detected while using Address Sanitation.
There was a problem hiding this comment.
Added back some data that I misread, and verified in testing (to be sure this time) that it is not bug causing, and does indeed provide needed functionality.
There was a problem hiding this comment.
My attempt at objc memory management to remove retained objects, so they're GC'd.
|
@IComplainInComments This PR is starting to become a mess. I'd suggest starting over and make just the changes I mentioned in the previous one + the MTL_GENERAL_SHADER_TYPE_TOTAL fix. Also, limit your scope just to the Metal renderer, Discord RPC is really not something we should modify. As for resources on Cemu: I don't know any honestly. |
Yeah I didnt mean to sync all that, I usually dont use Xcode, and its ruining my flow. Ill get this cleaned up and resubmit. |
2 participants
Here is the new pull request without the use of
autorelease, Im not master at Objective-C memory management so please ignore how primitive it is.