Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading to Angular 8 #35

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Upgrading to Angular 8 #35

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d843432
- Upgrading to Angular 8.
Dec 13, 2019
bce670e
- Specify typescript version.
Dec 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 18 additions & 17 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "ngx-embed-video",
"version": "1.0.4",
"version": "1.1.4",
"scripts": {
"build": "ngc -p tsconfig.json",
"lint": "tslint --force --project tsconfig.json src/*.ts",
Expand All @@ -22,40 +22,41 @@
"keywords": [
"typescript",
"angular",
"angular6",
"angular8",
"ng",
"ng6",
"ngx",
"embed-video",
"embed",
"typescript",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove typescript tag?

Copy link
Author

@Abdulrahmanh995 Abdulrahmanh995 Dec 13, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed it as it's duplicated. It's at the top of this list.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! 👌

"youtube",
"vimeo",
"dailymotion",
"video"
"video",
"iframe"
],
"license": "MIT",
"bugs": {
"url": "https://github.com/SamirHodzic/ngx-embed-video/issues"
},
"main": "./dist/index.js",
"peerDependencies": {
"@angular/core": "^6.0.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove this & remove common but not core?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ng update command took care of this 🙂.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good so 👌

"@angular/common": "^6.0.0"
"@angular/core": "^6.0.0"
},
"devDependencies": {
"@angular/common": "^6.1.10",
"@angular/compiler": "^6.1.10",
"@angular/compiler-cli": "^6.1.10",
"@angular/core": "^6.1.10",
"@angular/http": "^6.1.10",
"@angular/platform-browser": "^6.1.10",
"@angular/platform-browser-dynamic": "^6.1.10",
"@angular/platform-server": "^6.1.10",
"@angular/animations": "^8.2.14",
"@angular/common": "^8.2.14",
"@angular/compiler": "^8.2.14",
"@angular/compiler-cli": "^8.2.14",
"@angular/core": "^8.2.14",
"@angular/http": "^7.2.15",
"@angular/platform-browser": "^8.2.14",
"@angular/platform-browser-dynamic": "^8.2.14",
"@angular/platform-server": "^8.2.14",
"@types/jasmine": "^2.8.9",
"codelyzer": "^4.5.0",
"core-js": "^2.5.7",
"jasmine-core": "^2.99.1",
"karma": "^1.7.0",
"karma": "^4.4.1",
"karma-chrome-launcher": "^2.2.0",
"karma-jasmine": "^1.1.2",
"karma-sourcemap-loader": "^0.3.7",
Expand All @@ -66,9 +67,9 @@
"ts-helpers": "^1.1.2",
"ts-loader": "^2.0.3",
"tslint": "^5.11.0",
"typescript": "^2.9.2",
"typescript": "~3.5.3",
"webpack": "^2.3.1",
"zone.js": "^0.8.26"
"zone.js": "^0.9.1"
},
"engines": {
"node": ">=0.8.0"
Expand Down