Fix locale placement #26
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this bug also affect the client side? |
|
Just server-side, I think. It's pretty obvious if you even just boot the dev server. I'm not entirely sure why it happens on the server - it is pretty weird. I guess they parse differently? I know that this still happens with current 1.19 fabric as well, as I've run into it before with my own mods. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mod currently has lang files under the minecraft namespace. This leads to an issue where it wipes out almost all locale strings that were loaded into that namespace, presumably all strings loaded before this mod. Which means that on server side, console outputs get replaced with just their keys, as theres no string to localize to.
This PR moves the locale strings under the structures compass namespace, repairing the console. I did this fix for my own sanity and am using my own build on my server, so feel free to accept or ignore.