Fix: Fix custom endpoint encoding (@W-20150841@) #435
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vcua-mobify
approved these changes
Nov 19, 2025
Contributor
vcua-mobify
left a comment
vcua-mobify
left a comment
There was a problem hiding this comment.
This looks good to me. Thanks for fixing it!
unandyala
approved these changes
Nov 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the path encoding for multi-segment paths in custom endpoints using the helper.callCustomEndpoint function:
Original Issue:
if your endpoint path had multiple segments, everything would get URI encoded, resulting in an invalid path:
'multi/segment/path/Special,Summer%' --> 'multi%2Fsegment%2Fpath%2FSpecial%2CSummer%25'
After the fix:
This PR adds a fix so only special characters get encoded and NOT the path / delimiter:
'multi/segment/path/Special,Summer%' --> 'multi/segment/path/Special%2CSummer%25'
Corresponding fix in the isomorphic SDK: SalesforceCommerceCloud/commerce-sdk-isomorphic#248