Skip to content

Fix snyk CI for feature OAS branch#432

Merged
joeluong-sfcc merged 2 commits intofeature/oasfrom
ju/fix-snyk
Aug 14, 2025
Merged

Fix snyk CI for feature OAS branch#432
joeluong-sfcc merged 2 commits intofeature/oasfrom
ju/fix-snyk

Conversation

@joeluong-sfcc
Copy link
Collaborator

@joeluong-sfcc joeluong-sfcc commented Aug 14, 2025

Fixes CI for: #423

We had open API generator as a dependency but we don't use it directly, we have it through RAML toolkit so we can remove it, commerce-sdk-isomorphic does not have this dependency either

This PR also bumps up commerce-sdk-core version

@joeluong-sfcc joeluong-sfcc requested a review from a team as a code owner August 14, 2025 21:37
@joeluong-sfcc joeluong-sfcc changed the base branch from main to feature/oas August 14, 2025 21:37
@@ -2953,6 +2953,7 @@
"version": "5.0.0",
"resolved": "https://registry.npmjs.org/@isaacs/brace-expansion/-/brace-expansion-5.0.0.tgz",
"integrity": "sha512-ZT55BDLV0yv0RBm2czMiZ+SqCGO7AvmOM3G/w2xhVPH+te0aKgFjmBvGlL1dH+ql2tgGO3MVrbb3jCKyvpgnxA==",
"dev": true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the "dev": true, expected?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, I believe it's a way of tagging dependencies as dev dependencies or real product dependencies

@joeluong-sfcc joeluong-sfcc merged commit 7780ed3 into feature/oas Aug 14, 2025
7 checks passed
@joeluong-sfcc joeluong-sfcc deleted the ju/fix-snyk branch August 14, 2025 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants