Fix snyk CI for feature OAS branch#432
Merged
joeluong-sfcc merged 2 commits intofeature/oasfrom Aug 14, 2025
Merged
Conversation
vcua-mobify
approved these changes
Aug 14, 2025
adamraya
reviewed
Aug 14, 2025
| @@ -2953,6 +2953,7 @@ | |||
| "version": "5.0.0", | |||
| "resolved": "https://registry.npmjs.org/@isaacs/brace-expansion/-/brace-expansion-5.0.0.tgz", | |||
| "integrity": "sha512-ZT55BDLV0yv0RBm2czMiZ+SqCGO7AvmOM3G/w2xhVPH+te0aKgFjmBvGlL1dH+ql2tgGO3MVrbb3jCKyvpgnxA==", | |||
| "dev": true, | |||
Contributor
There was a problem hiding this comment.
Is the "dev": true, expected?
Collaborator
Author
There was a problem hiding this comment.
yes, I believe it's a way of tagging dependencies as dev dependencies or real product dependencies
adamraya
approved these changes
Aug 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes CI for: #423
We had open API generator as a dependency but we don't use it directly, we have it through RAML toolkit so we can remove it, commerce-sdk-isomorphic does not have this dependency either
This PR also bumps up
commerce-sdk-coreversion