Update CI to use node 22 @W-16170810@ #178
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unandyala
approved these changes
Jan 14, 2025
| @@ -9,7 +9,8 @@ jobs: | |||
| linux-tests: | |||
| strategy: | |||
| matrix: | |||
| node: [12, 14, 16, 18] | |||
| # TODO: remove older versions of node | |||
| node: [12, 14, 16, 18, 20, 22] | |||
There was a problem hiding this comment.
Just curious - Is there a specific reason why we want to remove older node versions ins a separate PR?
There was a problem hiding this comment.
Yes, the plan is to remove the older node versions when we drop official support for them, which is a breaking change, so we plan to remove them in the next major version most likely when we release the OAS SDK
alexvuong
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the publish and test workflows to use node 22
This PR also switches the
bundlesizepackage for thebundlesize2package asyarn installwas failing due to a transitive dependencyiltorbinbundlesizethat is not supported in newer node versions.There will be a follow up PR in the future to remove old node versions from the CI when we drop official support for them.
NOTE: we're holding off on merging this until bundlesize2 is approved as a 3PP