Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Fix dnt flag #170

Merged
merged 1 commit into from
Aug 21, 2024
Merged

[Bug] Fix dnt flag #170

merged 1 commit into from
Aug 21, 2024

Conversation

kevinxh
Copy link
Contributor

@kevinxh kevinxh commented Aug 21, 2024

There was a bug when the dnt flag is set to false, it will be omitted. This isn't what we want. This PR is to fix this issue.

before

...(parameters.dnt && {dnt: parameters.dnt.toString()}),

after

...(parameters.dnt !== undefined && {dnt: parameters.dnt.toString()}),

@kevinxh kevinxh requested a review from a team as a code owner August 21, 2024 15:56
@kevinxh kevinxh merged commit fadc6c1 into main Aug 21, 2024
8 checks passed
@kevinxh kevinxh deleted the fix-dnt branch August 21, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joeluong-sfcc joeluong-sfcc joeluong-sfcc approved these changes

@unandyala unandyala unandyala approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kevinxh @unandyala @joeluong-sfcc