Update SLAS helper to require channel_id

[joeluong-sfcc]

Starting 7/31/2024, SLAS will start requiring the channel_id as a required argument when retrieving an access token with grant_type: 'client_credentials for security purposes. This PR updates the loginGuestUserPrivate SLAS helper function to require channel_id.

[adamraya]

Not related to this change but I see the loginGuestUserPrivate is async, yet I don't see any await statement inside the function.

Are we missing an await statement here?

commerce-sdk-isomorphic/src/static/helpers/slasHelper.ts

Line 206 in ba0e1a9

return slasClient.getAccessToken(options);

return await slasClient.getAccessToken(options);

[joeluong-sfcc]

Not related to this change but I see the loginGuestUserPrivate is async, yet I don't see any await statement inside the function.

Are we missing an await statement here?

commerce-sdk-isomorphic/src/static/helpers/slasHelper.ts

Line 206 in ba0e1a9

return slasClient.getAccessToken(options);

return await slasClient.getAccessToken(options);

@adamraya Someone can correct my javascript knowledge if its incorrect, but I believe that marking a function with async means that return value is automatically a promise, so although we don't use await statements, we return a Promise<TokenResponse>

[adamraya]

Someone can correct my javascript knowledge if its incorrect, but I believe that marking a function with async means that return value is automatically a promise, so although we don't use await statements, we return a Promise<TokenResponse>

Yes you're right, the function marked with async automatically returns a promise. It will not wait for getAccessToken to resolve before returning, but I guess subsequent operations are handled in getAccessToken.