-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@W-14758586: Support slas client #140
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I played around with the test script and everything seems to be good to go.
One thing I am curious about the warning. Since it always appears, is there a possibility of the warning appearing on a production site and an end shopper seeing the warning?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for looking into the warning @alexvuong and for applying the feedback.
This PR adds support for SLAS private client without making a breaking change.
How to test
git clone [email protected]:SalesforceCommerceCloud/commerce-sdk-isomorphic.git
git checkout support-slas-client