Merge pull request #54 from agustin/fix-real_tcp-call

Propagates positional and keyword arguments to the real_tcp method

lib/tcr.rb

@@ -90,11 +90,11 @@ class Socket
   class << self
     alias_method :real_tcp, :tcp
 
-    def tcp(host, port, *socket_opts)
+    def tcp(host, port, *local_args, **timeout_opts)
       if TCR.configuration.hook_tcp_ports.include?(port)
         TCR::RecordableTCPSocket.new(host, port, TCR.cassette)
       else
-        real_tcp(host, port, *socket_opts)
+        real_tcp(host, port, *local_args, **timeout_opts)
       end
     end
   end

spec/tcr_spec.rb

@@ -523,4 +523,18 @@
       end
     }.not_to raise_error
   end
+
+  context "when port is not in hook_tcp_ports" do
+    it "it honors Socket.tcp keyword arguments" do
+      TCR.configure { |c|
+        c.hook_tcp_ports = [8080]
+        c.cassette_library_dir = "."
+      }
+
+      TCR.use_cassette("test") do
+        sock = Socket.tcp("google.com", 80, connect_timeout: 1, resolv_timeout: 1)
+        expect(sock).to be_a(Socket)
+      end
+    end
+  end
 end