-
Notifications
You must be signed in to change notification settings - Fork 35
chore(reset): remove PR prompt flow #106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Changes from 4 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
e3680c4
chore(reset): remove PR prompt flow
ymkiux a89b22f
feat(plugins): add builtin rule acknowledgement template
ymkiux c519576
feat(plugins): show creator and maintainers
ymkiux d5de2cc
chore(plugins): use github handles for ownership
ymkiux 6abbd58
refactor(plugins): split builtin templates into folders
ymkiux e838719
refactor(plugins): flatten builtin template folders
ymkiux f9b4432
chore(plugins): generate registry from folders
ymkiux c40bdee
chore(plugins): bind ownership to plugin id
ymkiux eec1cf3
chore(templates): bind ownership to template id
ymkiux ec4a171
refactor(templates): centralize ownership map
ymkiux 35669e0
style(usage): cap top paths height
ymkiux 23c855d
fix(plugins): avoid runtime ownership crash
ymkiux 30daad0
style(usage): reduce top paths whitespace
ymkiux 5da3e5d
style(usage): avoid gaps for top paths card
ymkiux File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,10 @@ | ||
| import { pluginOwnership } from './ownership.mjs'; | ||
|
|
||
| export const pluginMeta = { | ||
| id: 'prompt-templates', | ||
| title: 'Prompt Templates', | ||
| description: 'Standardized, template-driven prompts with variables and copy/export helpers.', | ||
| statusLabel: 'standard', | ||
| tone: 'configured' | ||
| tone: 'configured', | ||
| ...pluginOwnership | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| export const pluginOwnership = { | ||
| createdBy: 'ymkiux', | ||
| maintainers: ['ymkiux'] | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Attribution string renders awkwardly when only one of
createdBy/maintainersis present.The
v-ifallows rendering when eithercreatedByormaintainers.lengthis truthy, but the binding always usesplugins.meta.attribution("Created by {createdBy} · Maintained by {maintainers}"). If a built-in template has only maintainers (or only a creator), the UI will display things likeCreated by · Maintained by ymkiux.The computed
pluginsActiveAttributioninplugins/prompt-templates/computed.mjs(lines 132-134) already handles this correctly by selecting betweenplugins.meta.attribution,plugins.meta.createdBy, andplugins.meta.maintainedBy. These inline template bindings should mirror that logic, or — simpler — expose a per-template attribution computed helper and bind it here (and at lines 189-191) to avoid duplicating the rendering rules.♻️ Sketch of an inline fix (duplicated in both locations)
A cleaner alternative is to add a computed
promptComposerActiveAttribution/promptTemplateDraftAttributionthat returns the resolved string (same shape aspluginsActiveAttribution) and bind{{ ... }}to it here.📝 Committable suggestion
🤖 Prompt for AI Agents