Upgrade Carbon Factory from v5.0.0 to v5.2.1 #1836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A Jest bug fix means the default testURL for tests is now http://localhost instead of `about:blank`. Update the router test args accordingly.
andrewjtait
approved these changes
Sep 11, 2018
|
Checked layouts, components, styles, and other features had not broken in Safari and Chrome browsers. Also checked source maps. Found some issues (CARBON-1103 - CARBON-1108) but not related to these changes. Tests passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade
carbon-factoryfromv5.0.0tov5.2.1, which enables source maps by default in the webpack config.Fixed a test in the router specs, as Jest now sets
testURLto localhost instead ofabout:blank.which enables source maps by default in the webpack config.