Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(WIP) Add GX data validation for synapse data warehouse #42

Merged
merged 15 commits into from
Sep 16, 2024

Conversation

thomasyu888
Copy link
Member

@thomasyu888 thomasyu888 commented May 18, 2024

Problem
There is currently very little data observability into the warehouse data, it is essential we run a validation suite so we peak into data validity within our warehouse

Solution
Add GX as our data validation layer.

  • Add snowflake data source
  • Add expectation suites
  • Create validator to execute the validation.
image

Tech Debt
Archive tf scripts for now so it doesn't confuse admins

@thomasyu888 thomasyu888 requested a review from a team as a code owner May 18, 2024 21:55
@thomasyu888 thomasyu888 changed the title Add GX data validation for synapse data warehouse (WIP) Add GX data validation for synapse data warehouse May 18, 2024
Copy link

sonarcloud bot commented May 20, 2024

Quality Gate Passed Quality Gate passed

Issues
48 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
2.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@BryanFauble BryanFauble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome. I'll go ahead and pre-approve here.

Are we able to run every table through these expectation suites, or is it set up to run them all after merge?

@thomasyu888
Copy link
Member Author

This is awesome. I'll go ahead and pre-approve here.

Are we able to run every table through these expectation suites, or is it set up to run them all after merge?

The idea is to run them each table through the expectation suite, but this should eventually live in the Orca repo as a data operation.

@thomasyu888 thomasyu888 merged commit 046160a into dev Sep 16, 2024
3 checks passed
@thomasyu888 thomasyu888 deleted the gx-data-validation branch September 16, 2024 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants