chore(openchallenges): update the OC API client for Angular and migrate from OpenAPI Generator v6.1.0 to v7.11.0#3132
Merged
tschaffter merged 12 commits intoMay 6, 2025
Conversation
5485e8b to
6b52c7f
Compare
Contributor
Author
Issue with query parametersA query currently looks like that: Using the same config as before: additionalProperties:
queryParamObjectFormat: keyThe parameter Most of the issue is solved when updating OpenAPI Generator from v7.12.0 to v7.13.0, but the remaining issue shown below remains on the home page (and possibly somewhere else): Currently (v6.1.0): In v7.13.0 This PR describes the fix introduced in v1.13.0 and references the original source of the issue with the query parameters. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the version of the OpenAPI Generator used for the OC API client for Angular from v6.1.0 to v7.11.0.
OpenAPI Generator v7.12.0 and v7.13.0 have issues related to how the query parameters are serialized. This PR updates the generator to v7.11.0, which is the most recent version that still work successfully.
The release notes for OpenAPI Generator:
While the above releases fixes some issues related to the serialization of the query parameters, in particular v7.13.0, the tickets shown below describe the remaining issue that prevent us from futher updating the OpenAPI generator.
Note
The custom API template has been removed, as it no longer appears necessary. The original motivation for introducing the custom template is unclear due to a lack of sufficiently granular commit history. If needed, the rationale could be reconstructed by comparing the official template with the custom one.
Related Issues
Changelog
templates/config.yamltoopenapitools.json.ng-package.jsonto depend on Angular 19+.Notes
BaseService.tsthat other services extends. This contributes to make the code more DRY.