Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorporate uniprot id into gene info #160

Open
wants to merge 12 commits into
base: dev
Choose a base branch
from

Conversation

beatrizsaldana
Copy link
Member

@beatrizsaldana beatrizsaldana commented Nov 23, 2024

AG-1392 - Incorporate uniprot ID into gene_info

Adding uniprotkb_accessions column to the gene_info dataset using the uniprot to ensembl mapping file (syn54113663).

Changes

  1. Updated config.yaml and test_config.yaml to include the uniprot mapping dataset
  2. Added function add_uniprot_id_to_gene_info() to add the uniprotkb_accessions column
  3. Added pass and fail tests for the add_uniprot_id_to_gene_info() function
  4. Added pass and fail assets for the add_uniprot_id_to_gene_info() function
  5. Updated existing gene_info tests to include a uniprotkb_accessions column
  6. Updated gene_info output assets to include a uniprotkb_accessions column
  7. Added ensg_to_uniprot_mapping_good.tsv to the gene_info testing assets
  8. Added gx validation for the uniprotkb_accessions column

Copy link

sonarcloud bot commented Nov 23, 2024

@beatrizsaldana beatrizsaldana marked this pull request as ready for review November 23, 2024 00:19
@beatrizsaldana beatrizsaldana requested a review from a team as a code owner November 23, 2024 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant