Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ETL-170] Generate test events from Synapse Dataset #63

Merged
merged 7 commits into from
Apr 9, 2022
Merged

Conversation

philerooski
Copy link
Contributor

See ticket for changes made: https://sagebionetworks.jira.com/browse/ETL-170

TLDR: We no longer store test data in this repo nor in an S3 bucket owned by us. Instead we reference Synapse datasets containing Bridge raw data entities to generate the test events.

Rather than copying files from the repo to S3, a versioned
Synapse Dataset is created or updated by querying a raw data folder
for dataset items. Test data will be hosted by Bridge, rather than by us.
Representative of all assessment IDs and versions available to us
currently.
@philerooski philerooski requested a review from a team as a code owner April 8, 2022 22:23
Copy link
Member

@thomasyu888 thomasyu888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments, but overall looks good.

src/lambda/events/generate_test_event.py Show resolved Hide resolved
src/lambda/events/generate_test_event.py Show resolved Hide resolved
src/lambda/events/generate_test_event.py Outdated Show resolved Hide resolved
src/lambda/events/generate_test_event.py Show resolved Hide resolved
@philerooski philerooski temporarily deployed to develop April 8, 2022 23:59 Inactive
@philerooski philerooski temporarily deployed to develop April 9, 2022 00:02 Inactive
@thomasyu888
Copy link
Member

@philerooski Feel free to merge after you fix the two return statements

@philerooski philerooski merged commit 7d45c1d into main Apr 9, 2022
@philerooski philerooski deleted the etl-170 branch April 9, 2022 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants