Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ETL-107] Add SQS template and config #60

Merged
merged 3 commits into from
Mar 25, 2022
Merged

[ETL-107] Add SQS template and config #60

merged 3 commits into from
Mar 25, 2022

Conversation

philerooski
Copy link
Contributor

This is just the SQS CFN template and an example config. The other work we've been doing (including moving the lambda to its own stack) will be included in the PR for ETL-117.

@philerooski philerooski requested a review from a team as a code owner March 24, 2022 23:55
Copy link
Contributor

@tthyer tthyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I just need a few more descriptive names.

What did you do with the lambda-specific commits to the etl-107 branch that we were making?

config/develop/sqs-queue.yaml Outdated Show resolved Hide resolved
config/develop/sqs-queue.yaml Outdated Show resolved Hide resolved
@philerooski philerooski temporarily deployed to develop March 25, 2022 22:19 Inactive
@philerooski philerooski temporarily deployed to develop March 25, 2022 22:22 Inactive
@philerooski
Copy link
Contributor Author

@tthyer I namespaced the SQS queue stack and borrowed the existing naming convention we've used for namespaced resources. I also added some SNS resources and policies to the SQS template in anticipation of removing those same resources from the lambda template.

@philerooski philerooski requested a review from tthyer March 25, 2022 22:31
Resources:

PrimaryQueue:
Type: AWS::SQS::Queue
Properties:
DelaySeconds: 0
MessageRetentionPeriod: 86400
QueueName: !Ref PrimaryQueueName
QueueName: !Sub '${AWS::StackName}-Queue'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better

@philerooski philerooski merged commit 82eacf8 into main Mar 25, 2022
@philerooski philerooski deleted the etl-107-mvp branch March 25, 2022 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants