-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ETL-107] Add SQS template and config #60
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I just need a few more descriptive names.
What did you do with the lambda-specific commits to the etl-107 branch that we were making?
@tthyer I namespaced the SQS queue stack and borrowed the existing naming convention we've used for namespaced resources. I also added some SNS resources and policies to the SQS template in anticipation of removing those same resources from the lambda template. |
Resources: | ||
|
||
PrimaryQueue: | ||
Type: AWS::SQS::Queue | ||
Properties: | ||
DelaySeconds: 0 | ||
MessageRetentionPeriod: 86400 | ||
QueueName: !Ref PrimaryQueueName | ||
QueueName: !Sub '${AWS::StackName}-Queue' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
better
This is just the SQS CFN template and an example config. The other work we've been doing (including moving the lambda to its own stack) will be included in the PR for ETL-117.