Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use uploadedOn rather than createdOn for derived year/month/day partition fields #38

Merged
merged 2 commits into from
Jan 21, 2022
Merged

Use uploadedOn rather than createdOn for derived year/month/day partition fields #38

merged 2 commits into from
Jan 21, 2022

Conversation

philerooski
Copy link
Contributor

@philerooski philerooski requested a review from a team as a code owner January 21, 2022 22:58
tthyer
tthyer approved these changes Jan 21, 2022
View reviewed changes
Copy link
Contributor

@tthyer tthyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We'll need to delete test data and recreate because metadata can only be added to S3 objects on creation.

@philerooski philerooski merged commit 86e52a5 into main Jan 21, 2022
@philerooski philerooski deleted the etl-97 branch January 21, 2022 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasyu888 thomasyu888 thomasyu888 approved these changes

@tthyer tthyer tthyer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@philerooski @tthyer @thomasyu888