Etl-76/pipeline fixes #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasyu888
reviewed
Oct 14, 2021
| @@ -7,7 +7,7 @@ dependencies: | |||
| - develop/glue-database.yaml | |||
| parameters: | |||
| SourceBucketName: !stack_output_external bridge-downstream-dev-source-bucket::BucketName | |||
| SourceKey: 'mtb-sample-data' | |||
| SourceKey: 'mtb-sample-data/0y38x2N2b4LHPBpZ-djfCoGx-raw.zip' | |||
There was a problem hiding this comment.
does this zip file ever change?
There was a problem hiding this comment.
This is just the setup at this phase of testing and will change soon. What's going to happen is that we will have a lambda that subscribes to an SNS topic. Messages will be published to that topic when there are new archives to process. The lambda will start the workflow run.
thomasyu888
approved these changes
Oct 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes various to get the pipeline working properly or improve configuration
Additionally, set up logging in s3_to_json_s3.py to ease debugging. It can use additional logging statements, and we should also set up logging in the other script eventually.