Skip to content

perf: improved performance of TabularDataset.__eq__ by a factor of up to 2 #697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lars-reimann merged 5 commits into from
May 6, 2024
Merged

perf: improved performance of TabularDataset.__eq__ by a factor of up to 2 #697

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
78596ad
perf: improved performance of `TabularDataset.__eq__` by a factor of …
Marsmaennchen221 May 3, 2024
1a38aea
style: apply automated linter fixes
megalinter-bot May 3, 2024
d8881ab
Update src/safeds/data/labeled/containers/_tabular_dataset.py
Marsmaennchen221 May 6, 2024
c2bfe4b
style: apply automated linter fixes
megalinter-bot May 6, 2024
1c4de0e
Merge branch 'main' of https://github.com/Safe-DS/Library into perf-i…
Marsmaennchen221 May 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/safeds/data/labeled/containers/_tabular_dataset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ def __eq__(self, other: object) -> bool:
return NotImplemented
if self is other:
return True
return self.target == other.target and self.features == other.features and self._table == other._table
return self.target == other.target and self.features == other.features and self._extras == other._extras

def __hash__(self) -> int:
"""
Expand All @@ -105,7 +105,7 @@ def __hash__(self) -> int:
hash:
The hash value.
"""
return _structural_hash(self.target, self.features, self._table)
return _structural_hash(self.target, self.features, self._extras)

def __sizeof__(self) -> int:
"""
Expand All @@ -116,7 +116,7 @@ def __sizeof__(self) -> int:
size:
Size of this object in bytes.
"""
return sys.getsizeof(self._target) + sys.getsizeof(self._features) + sys.getsizeof(self._table)
return sys.getsizeof(self._target) + sys.getsizeof(self._features) + sys.getsizeof(self._extras)

# ------------------------------------------------------------------------------------------------------------------
# Properties
Expand Down