Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: When using from_table_to_time_series, feature must be given #571

Closed
Gerhardsa0 opened this issue Mar 6, 2024 · 1 comment · Fixed by #572
Closed

bug: When using from_table_to_time_series, feature must be given #571

Gerhardsa0 opened this issue Mar 6, 2024 · 1 comment · Fixed by #572
Assignees
@Gerhardsa0
Labels
bug 🪲 Something isn't working released Included in a release

Comments

@Gerhardsa0
Copy link
Contributor

Gerhardsa0 commented Mar 6, 2024 •
edited
Loading

Describe the bug

when using the from_table_to_time_series features must be given right now, because of the used tagged table function.

To Reproduce

calls TimeSeries.from_table_to_time_series without features

Expected behavior

the user should call it without an given feature
@Gerhardsa0 Gerhardsa0 added the bug 🪲 Something isn't working label Mar 6, 2024
@github-project-automation github-project-automation bot moved this to Backlog in Library Mar 6, 2024
@Gerhardsa0 Gerhardsa0 self-assigned this Mar 6, 2024
@Gerhardsa0 Gerhardsa0 mentioned this issue Mar 15, 2024
Merged
@Gerhardsa0 Gerhardsa0 linked a pull request Mar 15, 2024 that will close this issue
feat: when using from table to time series feature must be given #572
Merged
lars-reimann pushed a commit that referenced this issue Mar 18, 2024
@Gerhardsa0 @megalinter-bot
feat: when using from table to time series feature must be given (#572)
ca23f0f 
Closes #571 

### Summary of Changes

TimeSeries no longer is subclass of TaggedTable only of Table
<!-- Please provide a summary of changes in this pull request, ensuring
all changes are explained. -->

---------

Co-authored-by: megalinter-bot <[email protected]>
@github-project-automation github-project-automation bot moved this from Backlog to ✔️ Done in Library Mar 18, 2024
lars-reimann pushed a commit that referenced this issue Apr 3, 2024
@semantic-release-bot
chore(release): 0.20.0 [skip ci]
98bccd0 
## [0.20.0](v0.19.0...v0.20.0) (2024-04-03)

### Features

* add deterministic hash methods to all types ([#573](#573)) ([f6a3ca7](f6a3ca7))
* add fnn functionality ([#529](#529)) ([ce53153](ce53153)), closes [#522](#522)
* add suffixes to models to indicate their task ([#588](#588)) ([d490dee](d490dee))
* added lag_plot ([#548](#548)) ([0fb38d2](0fb38d2)), closes [#519](#519)
* added normal plot for time series ([#550](#550)) ([dbdf11e](dbdf11e)), closes [#549](#549)
* when using from table to time series feature must be given ([#572](#572)) ([ca23f0f](ca23f0f)), closes [#571](#571)

### Bug Fixes

* incorrect type hint for `number_of_bins` parameter ([#567](#567)) ([b434e53](b434e53))
* mark various API elements as internal ([#587](#587)) ([ea176fc](ea176fc)), closes [#582](#582) [#585](#585)
@lars-reimann
Copy link
Member

🎉 This issue has been resolved in version 0.20.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Gerhardsa0 Gerhardsa0

Labels
bug 🪲 Something isn't working released Included in a release
Projects
Library
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: when using from table to time series feature must be given Safe-DS/Library
2 participants
@lars-reimann @Gerhardsa0