Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: mark constraint lists as experimental #752

Merged
merged 1 commit into from
Nov 10, 2023
Merged

feat: mark constraint lists as experimental #752

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions packages/safe-ds-lang/src/language/validation/experimentalLanguageFeatures.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import {
isSdsIndexedAccess,
isSdsMap,
isSdsUnionType,
SdsConstraintList,
SdsIndexedAccess,
SdsLiteralType,
SdsMap,
Expand All @@ -11,6 +12,14 @@ import { hasContainerOfType, ValidationAcceptor } from 'langium';

export const CODE_EXPERIMENTAL_LANGUAGE_FEATURE = 'experimental/language-feature';

export const constraintListsShouldBeUsedWithCaution = (node: SdsConstraintList, accept: ValidationAcceptor): void => {
accept('warning', 'Constraint lists & constraints are experimental and may change without prior notice.', {
node,
keyword: 'where',
code: CODE_EXPERIMENTAL_LANGUAGE_FEATURE,
});
};

export const indexedAccessesShouldBeUsedWithCaution = (node: SdsIndexedAccess, accept: ValidationAcceptor): void => {
if (hasContainerOfType(node.$container, isSdsIndexedAccess)) {
return;
Expand Down
3 changes: 2 additions & 1 deletion packages/safe-ds-lang/src/language/validation/safe-ds-validator.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ import {
import { singleUseAnnotationsMustNotBeRepeated } from './builtins/repeatable.js';
import { annotationCallMustHaveCorrectTarget, targetShouldNotHaveDuplicateEntries } from './builtins/target.js';
import {
constraintListsShouldBeUsedWithCaution,
indexedAccessesShouldBeUsedWithCaution,
literalTypesShouldBeUsedWithCaution,
mapsShouldBeUsedWithCaution,
Expand Down Expand Up @@ -221,7 +222,7 @@ export const registerValidationChecks = function (services: SafeDsServices) {
classMustNotInheritItself(services),
],
SdsClassBody: [classBodyShouldNotBeEmpty],
SdsConstraintList: [constraintListShouldNotBeEmpty],
SdsConstraintList: [constraintListsShouldBeUsedWithCaution, constraintListShouldNotBeEmpty],
SdsDeclaration: [
nameMustNotStartWithCodegenPrefix,
nameShouldHaveCorrectCasing,
Expand Down
4 changes: 4 additions & 0 deletions ...ng/tests/resources/validation/experimental language feature/constraint lists/main.sdstest
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
package tests.validation.experimentalLanguageFeature.constraintLists

// $TEST$ warning "Constraint lists & constraints are experimental and may change without prior notice."
fun myFunction() »where« {}