Skip to content

feat: show placeholders in outline #1286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lars-reimann merged 1 commit into from
Dec 20, 2024
Merged

feat: show placeholders in outline #1286

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions packages/safe-ds-lang/src/language/lsp/safe-ds-document-symbol-provider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import {
isSdsAttribute,
isSdsClass,
isSdsEnumVariant,
isSdsExpression,
isSdsFunction,
isSdsPipeline,
isSdsSegment,
Expand Down Expand Up @@ -52,6 +53,18 @@ export class SafeDsDocumentSymbolProvider extends DefaultDocumentSymbolProvider
} else {
return undefined;
}
} else if (isSdsPipeline(node)) {
if (node.body) {
return super.getChildSymbols(document, node.body);
} else {
return undefined;
}
} else if (isSdsSegment(node)) {
if (node.body) {
return super.getChildSymbols(document, node.body);
} else {
return undefined;
}
} else {
return super.getChildSymbols(document, node);
}
Expand All @@ -62,9 +75,8 @@ export class SafeDsDocumentSymbolProvider extends DefaultDocumentSymbolProvider
isSdsAnnotation(node) ||
isSdsAttribute(node) ||
isSdsEnumVariant(node) ||
isSdsFunction(node) ||
isSdsPipeline(node) ||
isSdsSegment(node)
isSdsExpression(node) ||
isSdsFunction(node)
);
}
}
14 changes: 14 additions & 0 deletions packages/safe-ds-lang/tests/language/lsp/safe-ds-document-symbol-provider.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,7 @@ describe('SafeDsSemanticTokenProvider', async () => {
val a = 1;

(q: Int) {
val b = 1;
yield r = 1;
};
}
Expand All @@ -145,6 +146,12 @@ describe('SafeDsSemanticTokenProvider', async () => {
{
name: 'p',
kind: SymbolKind.Function,
children: [
{
name: 'a',
kind: SymbolKind.Variable,
},
],
},
],
},
Expand All @@ -155,6 +162,7 @@ describe('SafeDsSemanticTokenProvider', async () => {
val a = 1;

(p: Int) {
val b = 1;
yield r = 1;
};
}
Expand All @@ -164,6 +172,12 @@ describe('SafeDsSemanticTokenProvider', async () => {
name: 's',
kind: SymbolKind.Function,
detail: '(p: Int) -> (r: Int)',
children: [
{
name: 'a',
kind: SymbolKind.Variable,
},
],
},
],
},
Expand Down