Skip to content

feat: prevent editing built-in stubs#1282

Merged
lars-reimann merged 2 commits intomainfrom
readonly-builtins
Dec 15, 2024
Merged

feat: prevent editing built-in stubs#1282
lars-reimann merged 2 commits intomainfrom
readonly-builtins

Conversation

@lars-reimann
Copy link
Member

@lars-reimann lars-reimann commented Dec 15, 2024

Summary of Changes

Prevent accidental edits to built-in stubs by marking them as read-only by default.

If users or other extension change the "files.readonlyInclude" setting, entries are merged, which is the desired behavior:

Values with primitive types and Array types are overridden, meaning a configured value in a scope that takes precedence over another scope is used instead of the value in the other scope. But, values with Object types are merged.

(source)

@lars-reimann lars-reimann changed the title feat: prevent editing builtin stubs feat: prevent editing built-in stubs Dec 15, 2024
@github-actions
Copy link

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ JSON jsonlint 1 0 0.12s
✅ JSON npm-package-json-lint yes no 0.4s
✅ JSON prettier 1 0 0 0.52s
✅ JSON v8r 1 0 6.51s
✅ REPOSITORY git_diff yes no 0.14s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@codecov
Copy link

codecov bot commented Dec 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.75%. Comparing base (fce761c) to head (140eb24).
Report is 46 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1282   +/-   ##
=======================================
  Coverage   99.75%   99.75%           
=======================================
  Files         114      114           
  Lines       12790    12790           
  Branches     4203     4203           
=======================================
  Hits        12759    12759           
  Misses         31       31           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lars-reimann lars-reimann merged commit d02c30a into main Dec 15, 2024
@lars-reimann lars-reimann deleted the readonly-builtins branch December 15, 2024 10:35
lars-reimann pushed a commit that referenced this pull request Jan 4, 2025
## [0.23.0](v0.22.0...v0.23.0) (2025-01-04)

### Features

* categorize API elements ([#1285](#1285)) ([3275900](3275900)), closes [#1243](#1243)
* optional error messages for constraints ([#1275](#1275)) ([fce761c](fce761c)), closes [#1082](#1082)
* prevent editing built-in stubs ([#1282](#1282)) ([d02c30a](d02c30a))
* show placeholders in outline ([#1286](#1286)) ([3880bfe](3880bfe))

### Bug Fixes

* subtype check for literal and union types ([#1288](#1288)) ([911881c](911881c))
* subtype check for literal and union types (part 2) ([#1289](#1289)) ([56284cf](56284cf))
* type inference for lambdas and their parameters ([#1304](#1304)) ([a9e070f](a9e070f))
@lars-reimann
Copy link
Member Author

🎉 This PR is included in version 0.23.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released Included in a release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant