Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streamline formatter tests #745

Closed
lars-reimann opened this issue Nov 9, 2023 · 0 comments · Fixed by #747
Closed

Streamline formatter tests #745

lars-reimann opened this issue Nov 9, 2023 · 0 comments · Fixed by #747
Assignees
Labels
released Included in a release testing 🧪 Additional automated tests

Comments

@lars-reimann
Copy link
Member

lars-reimann commented Nov 9, 2023

Is your feature request related to a problem?

The formatter tests go a little overboard with the combinations they test.

Desired solution

Extract the tests for formatter elements that are called in different places, e.g. for parameters and type parameters.

Possible alternatives (optional)

No response

Screenshots (optional)

No response

Additional Context (optional)

No response

@lars-reimann lars-reimann added the enhancement 💡 New feature or request label Nov 9, 2023
@lars-reimann lars-reimann added this to DSL Nov 9, 2023
@github-project-automation github-project-automation bot moved this to Backlog in DSL Nov 9, 2023
@lars-reimann lars-reimann added testing 🧪 Additional automated tests and removed enhancement 💡 New feature or request labels Nov 9, 2023
@lars-reimann lars-reimann self-assigned this Nov 9, 2023
@lars-reimann lars-reimann linked a pull request Nov 9, 2023 that will close this issue
lars-reimann added a commit that referenced this issue Nov 9, 2023
Closes #745

### Summary of Changes

Formatting tests were difficult to maintain since several tests were
testing the same rules in different contexts, including the formatting
for
* lists of constraints,
* lists of parameters,
* lists of results,
* lists of type parameter,
* classes (global vs. nested),
* enum (global vs. nested),
* functions (global vs. method).

This made changes and additions cumbersome. This PR extracts the tests
for these rules and removes the redundant ones.
@github-project-automation github-project-automation bot moved this from Backlog to ✔️ Done in DSL Nov 9, 2023
@lars-reimann lars-reimann added the released Included in a release label Nov 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Included in a release testing 🧪 Additional automated tests
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant