Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sachin add privkey module #1

Merged
merged 28 commits into from
Feb 13, 2021
Merged

Sachin add privkey module #1

merged 28 commits into from
Feb 13, 2021

Conversation

SachinMeier
Copy link
Owner

  • add private key module in secp256k1
  • add basic testing for private key.
  • fix typo in math.ex

TODO

  • add signature serialization
  • add more testing for private key and signing

@SachinMeier
Copy link
Owner Author

I'm not familiar with testing practices, so I've only added a few tests for each function. More thorough test cases are required.

@SachinMeier SachinMeier merged commit a92dbc3 into master Feb 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SachinMeier @philipglazman