Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Foolproof: Disable VAD if clip_timestamps is in use #769

Merged
merged 2 commits into from
Apr 2, 2024

Conversation

Purfview
Copy link
Contributor

Prevent silly things to happen.

@trungkienbkhn
Copy link
Collaborator

@Purfview , could you provide an example of the strange behavior if using both vad_filter and clip_timestamp ?

@Purfview
Copy link
Contributor Author

Purfview commented Apr 2, 2024

@Purfview , could you provide an example of the strange behavior if using both vad_filter and clip_timestamp ?

clip_timestamps is like custom/manual VAD and it runs after Silero VAD code. Them both running at same time doesn't make sense.

For example, if you want to transcribe only the third minute of audio and set clip_timestamps="120,180", if vad_filter is enabled then audio for clip_timestamps can be different and the third minute wouldn't be at "120,180" anymore, transcription would happen at some unknown portion of audio.

@trungkienbkhn
Copy link
Collaborator

Okay. But I think you should add a comment or logging for this update logic code: vad_filter will be ignored if clip_timestamp is used.

@Purfview
Copy link
Contributor Author

Purfview commented Apr 2, 2024

Comment added.

@nguyendc-systran nguyendc-systran merged commit b024972 into SYSTRAN:master Apr 2, 2024
3 checks passed
@Purfview Purfview deleted the patch-1 branch April 2, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants