Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PERF: avoid stacking in input creation and isclose comparisons #62

Merged
merged 2 commits into from
Nov 15, 2024
Merged

PERF: avoid stacking in input creation and isclose comparisons #62

merged 2 commits into from
Nov 15, 2024

Commits on Nov 15, 2024

  1. PERF: Avoid stacking numpy arrays and pre-allocate our needed arrays 

    We can stack the arrays manually by setting the contents directly
through Numpy's indexing. Additionally, this way we can allocate
the arrow with Fortran ordering so it should be faster to pass
to the underlying codes.
    @greglucas
    greglucas committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    6f8d2d7 View commit details
    Browse the repository at this point in the history

  2. PERF: Replace isclose() comparison with explicit bounds 

    Rather than using isclose() we can directly compare against the
expected values using array indexing.
    @greglucas
    greglucas committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    0471f96 View commit details
    Browse the repository at this point in the history