Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge dev to main #255

Merged
merged 62 commits into from
Oct 12, 2022
Merged

merge dev to main #255

merged 62 commits into from
Oct 12, 2022

Conversation

haryung-lee
Copy link
Member

No description provided.

haryung-lee and others added 30 commits October 4, 2022 15:34
…수-있다

FIRE-715-친구의-프로필-화면에서-친구-삭제를-할-수-있다
…permission-에러-해결

FIRE-730 fix safari navigator & sinkId error
071yoon and others added 24 commits October 10, 2022 17:12
…-수-있다

FIRE-733 나의 깃허브 블로그 이메일 정보를 확인할 수 있다
- add profile that shows no user
- remove user api json -> used for mock before BE API
- improve edit group -> enable space while typing
@haryung-lee haryung-lee requested a review from 071yoon October 12, 2022 12:30
@cypress
Copy link

cypress bot commented Oct 12, 2022



Test summary

18 2 0 0


Run details

Project Default Project
Status Failed
Commit 27b67fd ℹ️
Started Oct 12, 2022 12:32 PM
Ended Oct 12, 2022 12:34 PM
Duration 02:16 💡
OS Linux Ubuntu - 20.04
Browser Chrome 106

View run in Cypress Dashboard ➡️


Failures

cypress/e2e/1-main-page/login.cy.ts Failed
1 try login > login success
2 try login > go to register

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

(block: blockInterface) => block.moderator.uid === uid,
);

newData?.sort((a, b) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

추후에 방들 current > createdAt 순서로 정렬


const { data } = useUser(Number(uid));
useEffect(() => {
// setInput state
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

주석삭제

@@ -1,4 +1,5 @@
import styled from 'styled-components';
import media from 'src/styles/media';
import Level from './Level';

export default function Badge() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

구현 필요

@@ -0,0 +1,349 @@
import React, { useEffect } from 'react';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리팩토링 필요

@@ -29,23 +30,33 @@ export default function ChattingItem({
}) {
const { uid } = userStore();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리팩토링 필요

avatar: number;
message: string;
createdAt: string;
type: string; // 'message' || 'join' || 'leave'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

enum 혹은 const로 빼주기

avatar: number;
message: string;
createdAt: string;
type: string; // 'message' || 'join' || 'leave'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

enum 혹은 const로 빼주기

Copy link
Member

@071yoon 071yoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@071yoon 071yoon merged commit 8f0ffe4 into main Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants