-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
merge dev to main #255
merge dev to main #255
Conversation
FIRE-711-privacy-policy-페이지-작성
FIRE-712-terms-페이지-작성
Fire 714 내가 만든 방을 상단에서 볼 수 있다
…수-있다 FIRE-715-친구의-프로필-화면에서-친구-삭제를-할-수-있다
FIRE-722-프로필-profile-uid-모바일뷰-설정
Fire 716 carousel 적용하기
…permission-에러-해결 FIRE-730 fix safari navigator & sinkId error
FIRE-729-프로필-화면에서-로딩중에-cls-방지
…-수-있다 FIRE-733 나의 깃허브 블로그 이메일 정보를 확인할 수 있다
FIRE-736 fix input to textarea
FIRE-734 add edit user profile page with mock data
Fire 644 을 누르면 코드 입력창이 생긴다
FIRE-743 apply BE API to FE profile
FIRE-744 return error to unauthenticated user
- add profile that shows no user - remove user api json -> used for mock before BE API - improve edit group -> enable space while typing
FIRE-745 add nouser profile
…볼-수-있다 FIRE-742 add code modal in code chatting
Test summaryRun details
View run in Cypress Dashboard ➡️ Failures
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
(block: blockInterface) => block.moderator.uid === uid, | ||
); | ||
|
||
newData?.sort((a, b) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
추후에 방들 current > createdAt 순서로 정렬
|
||
const { data } = useUser(Number(uid)); | ||
useEffect(() => { | ||
// setInput state |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
주석삭제
@@ -1,4 +1,5 @@ | |||
import styled from 'styled-components'; | |||
import media from 'src/styles/media'; | |||
import Level from './Level'; | |||
|
|||
export default function Badge() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
구현 필요
@@ -0,0 +1,349 @@ | |||
import React, { useEffect } from 'react'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
리팩토링 필요
@@ -29,23 +30,33 @@ export default function ChattingItem({ | |||
}) { | |||
const { uid } = userStore(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
리팩토링 필요
avatar: number; | ||
message: string; | ||
createdAt: string; | ||
type: string; // 'message' || 'join' || 'leave' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
enum 혹은 const로 빼주기
avatar: number; | ||
message: string; | ||
createdAt: string; | ||
type: string; // 'message' || 'join' || 'leave' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
enum 혹은 const로 빼주기
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
No description provided.