-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIRE-208-study-webrtc-세미나-준비-윤영기 #21
Merged
The head ref may contain hidden characters: "FIRE-208-study-webrtc-\uC138\uBBF8\uB098-\uC900\uBE44-\uC724\uC601\uAE30"
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Atom 폴더에 있는 Button 쓰지 않아 삭제
calculate helper 쓰지 않기에 삭제
…208-study-webrtc-세미나-준비-윤영기
video.tsx 삭제
원래 webcam을 활용한 공유에서 display를 공유하는 형태로 변경
parameter 사용시에 type을 지정하는 경우, 어쩔 수 없이 unused var를 사용해야함 parameter에서만 '_' + variable name 을 지정할 수 있게 해 예외처리
room.tsx에 설명 달린 주석 추가
add comment at peerconnectionSession and useStartPeerSession
medaiStream state 없어도 잘 작동하는지 테스트
PeerConnectionSession과 useStartPeerSession에 주석 추가
edit prettierrc for windows env
env 환경에서 작업하기 쉽도록 코드에서 URL 분리
보안상 pem키 ignore
Room.tsx가 겹쳐 RoomBlocks로 재설정
http와 https에 따라 다른 설정값 추가
사용하지 않는 환경설정 삭제
define type for PeerConnectionSession
localhost 에서 virtual ip로 수정
remote stream 100ms 로 tune up
필요없는 주석 삭제
…208-study-webrtc-세미나-준비-윤영기
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
haryung-lee
reviewed
Jul 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고하셨어요!👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.