Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: YAML editor does not load when installing Stratos Helm Chart #517

Merged
merged 3 commits into from
Oct 5, 2020

Conversation

nwmac
Copy link
Member

@nwmac nwmac commented Oct 2, 2020

Fixes #516

@nwmac nwmac added bug Something isn't working ready for review Ready for review labels Oct 2, 2020
@nwmac nwmac self-assigned this Oct 2, 2020
@codecov-commenter
Copy link

codecov-commenter commented Oct 2, 2020

Codecov Report

Merging #517 into master will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #517      +/-   ##
==========================================
- Coverage   57.80%   57.80%   -0.01%     
==========================================
  Files        1061     1061              
  Lines       34403    34405       +2     
  Branches     4891     4892       +1     
==========================================
  Hits        19888    19888              
- Misses      14515    14517       +2     

Copy link
Member

@richard-cox richard-cox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Spotted a couple of other bugs though, raised in cloudfoundry#4629

@richard-cox richard-cox merged commit 8004c21 into master Oct 5, 2020
@richard-cox richard-cox deleted the helm-merge-error branch October 5, 2020 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ready for review Ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Helm Install: YAML editor does not load when installing Stratos chart
3 participants