Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update kube pod container component following ux review #441

Merged
merged 2 commits into from
Aug 25, 2020
Merged

Update kube pod container component following ux review #441

merged 2 commits into from
Aug 25, 2020

Conversation

richard-cox
Copy link
Member

@richard-cox richard-cox added the ready for review Ready for review label Aug 17, 2020
@richard-cox richard-cox self-assigned this Aug 17, 2020
@codecov-commenter
Copy link

Codecov Report

Merging #441 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #441   +/-   ##
=======================================
  Coverage   56.28%   56.28%           
=======================================
  Files         898      898           
  Lines       29318    29318           
  Branches     4234     4234           
=======================================
  Hits        16501    16501           
  Misses      12817    12817

@richard-cox
Changes following review
7a1e843 
- smaller icon
- re-add container probes
nwmac
nwmac approved these changes Aug 25, 2020
View reviewed changes
Copy link
Member

@nwmac nwmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nwmac nwmac merged commit 3502fb5 into master Aug 25, 2020
@nwmac nwmac deleted the pod-container-improvements branch August 25, 2020 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nwmac nwmac nwmac approved these changes

Assignees

@richard-cox richard-cox

Labels
comments-addressed ready for review Ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Container List in Pods List Improvements
3 participants
@richard-cox @codecov-commenter @nwmac