Merge upstream/v2-master #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Ensure that, on redirect, we subscribe to result - For manage users stepper, ensure we can re-enable the button after click and redirect succesfully on next - Make manager user apply button work as per delete app
- Tweak confirm table columns - Remove selected users list from select roles step - Tweal step names - Fix after merge - roles table change todo
…ponent initial load indicator
…irect and single user)
…rt with multi users - This was brought up in demo - Needed in some cases for warm fuzzies (user has preselected users list, either single or multiple) - Only case where we might not show it is when the select users step is shown, however for consistency felt it should be the same for all
- The ngIf on selected users which determines if the step is visible flipped - This caused the table to disconnect, which was never connected again - Not sure how the step was even still visible
- Fix issue in master where select column/multi actions not showing - Fix manage users selection columns
- Ensure there's no dups in org spaceGuids list - Fetch list of spaceGuids from org and not space object - Wire in new all spaces
This reverts commit b5ec5c2.
- tested for admin/non admin - admin read-only needs to be applied later on - doppler.firehose scope wasn't required to show the firehose
Add code coverage config file
Cloud Foundry: Manage Users
* v2-master: (25 commits) Add code coverage config file Add user info to the response when connecting an endpoint Fix selection following merge - Fix issue in master where select column/multi actions not showing - Fix manage users selection columns Fix return to select users step (missing user rows) - The ngIf on selected users which determines if the step is visible flipped - This caused the table to disconnect, which was never connected again - Not sure how the step was even still visible Fix redirect for states without query params Re-add selected users list to modify roles step, fixed title when start with multi users - This was brought up in demo - Needed in some cases for warm fuzzies (user has preselected users list, either single or multiple) - Only case where we might not show it is when the select users step is shown, however for consistency felt it should be the same for all Fix stepper blocked indicator (failed to populate cf/users when nav direct and single user) Ensure query params are retained through auth guard/login redirect Allow single user refresh of stepper Tweak fetch org to handle failures Add loading indicator to select role step via app-table, fix list-component initial load indicator Change following review Fix lint + tests Fix ExpressionChanged when returning to manage users stepper Fix removal of org user + other roles for multiple users Fix after merge Fix cc Tweak confirm table Use table for org roles Changes following review - Tweak confirm table columns - Remove selected users list from select roles step - Tweal step names - Fix after merge - roles table change todo ...
…verflow Overflow table row select's selection animation
…ssions-2 Apply user permissions to CF pages - 2
richard-cox
added a commit
that referenced
this pull request
Apr 24, 2019
richard-cox
added a commit
that referenced
this pull request
Apr 26, 2019
* Fix endpoint table --> card error * Fix tidy up bug * Add frontend endpoint sub types, wire up to k8s types - Note - Missing k8s images pending review * Update icon font * Fix lint issue * Update icons * Fixed lint error, tweaked naming and access * Allow endpoint types to reference common core endpoint auth types - stops references of package code in common code - prep for moving metrics into own package (just need to register metricType obj via decorators) * Add images for k8s * Kube dashboard * Post merge fixes * Updates * Editor config change * Applciation sub nav and sub nav changes * Fix backend build script * Fix helm module * Add favorite to kube endpoint * Fix endpoint card favorite star * Remove unneeded favorite config * Add API to determine if kube dashboard is installed * Fix compilation issues * Fix for endpoint favorite card when endpoint type is not known * Add support for icon mode and a few tidy ups * Add base kubernetes summary view * WIP Kube summary charts * Fix after merge * Various fixes and tweaks * Added simple usage chart and pod usage * Add status graphs * Little bit of tidy up on kube summary page * Fix unit tests * Tidy up kube summary * Fix code climate issues * Fix lint issue * Fix merge issues * Fix multiple app stats requests on org & space summary pages - Recent changes to obs chains make them more emitty - Ensure when we watch apps collection changes that we only fire stats off once * Fix endpoint card details * Update GKE given subtype changes * Add smoother tile layout breakpoints (once nav side bar changes come in there should be no cut off tile) * Latest updates * Add tab labels and icons * Fix delete button missing and missing icon * PR Fixes * Remove warning on startup * Changes following review * Fixes and updates * Fix compilation errors * Temp fix for tables with cells that use `white-space: nowrap;` and have a loooong words * Merge fixes * chip pills are now not bold * Endpoint status updates * Disable connect of endpoint types that don't support it * Sidenav icon * Add helm status to endpoint lists - Note - we may want to find another pluggable way of showing custom status text/icons * Move view namespace in dashboard link to own column, only show if we have the dashboard * Add loading indicator to k8s summary page to avoid graph flicker * Split out yaml overrides into second step in install helm chart - moved step1 into core step as there's not a lot of code - could also split out name/namespace * Update all metrics icons to `equalizer` * Release status & ensure all GetAllEndpoints actions result in a GetSystemSuccess - use same endpoint status on helm/releases as endpoint list - we were using the GetAllEndpoints action when working with lists of endpoints.. however this actually did nothing. Now we fire off a GetSystemSuccess whenever we dispatch GetAllEndpoints * Remove pod image & tag columns, add `Ready Containers` using `containerStatuses` * Various updates * Fix endpoint notification. Tidy up logging * Add helm versions list to helm config tab * Also show 'not installed' in helm config versions table * Fix release resource parsing * Add pods page & list to helm release page * Add majority of helm release services page & list Only thing missing should be the populate of fields in the card, the data is available though just a bit of wiring needed * susecon script * Tidy up kube summary page * Tweaks/Fixes to Helm Release Services * Tidy up release loading indicators * Ensure all padding is consistent with dashboard component * Add services view to kubernetes namespace page - to do so made base kube services list config and data source classes - Tweaked kuberetes 'application' name to be inline with labels on how to get there * Minor improvements regarding kube/helm row uniqueness. Handle helm errors better * Show helm release service cards quicker * Only show install button if we have connected k8s & only show connected k8s in install stepper * Improve helm install yaml overrides text box - onEnterOverrides unglyness needed due to.. - size of textbox not autosizing properly - visuals of textbox without focus not so nice * fetchHelmReleaseFromKubernetes --> fetchHelmReleaseServiceFromKubernetes * Update kube service info when refreshing helm release service list * Add service link in helm release services list - will not show as link in other services lists * Fix sub header title with url param * Fix no-margin style name change * Status updates * Add base step to application creation. * CC Fixes * E2e fixes * Unit test fixes * Unit test fix * Unit test fix * Change cf favorite deploy menu item to create * Fix home page margins * Fix kubeService$ error on start up - works fine, just the compiler being strict * Add wait for release status to release summary loading indicator - also unsub from pod data chain * Fix deleting indicator on helm release page * Removed debug console.log * Tidy up helm release summary tab * Make the kube summary layout reusable and apply to helm release summary * Improve helm views incluing release and chart summary * Missed file updates * Added theme for entity title summary component * Tighten up the side nav and revert hover change * Added icon mode to new nav * Fix mobile nav closing * WIP * Impove sidenav auto hiding * WIP * Fix unit tests * Fix auth type select width * Fix side nav on firefox * Improve sidenav styling * Overflow fix for nav top section * Fix e2e tests, add one more for connect in stepper * Small tidies/fixes * helm install reduxing * Remove HelmReleaseLinkComponent and use cellDefinition link config * Remove unused HelmRepositoryCountComponent * Improve typing * fix imports * Use common page size with defaultHelmKubeListPageSize * small tidy ups * Changes following review * Small fixes, cater for endpoints that don't require connecting when showing 'no connected' snackbard * Ensure health check respects doesNotSupportConnect * more minor tidy ups * Use app-no-content-message in release notes & values pages * Fix and use common `unique` function for helm entities & data sources * minor tidyups * More fixes - ensure all helm & kube entity & row unique functions are correct - update some lists to use valuePath instead of getValue - typo fixes - note on dashboard & margin bug - comment out some todos * Improve kube typing and use common getKubeAPIResourceGuid * Re-add shared connection icon to endpoint name - TODO: add to endpoint card * Show shared connection notification in endpoint card * Fix endpoint checking label * Show cancel/close button on connect endpoint dialog - if the cf is dodgy and not responding the user should be able to exit the modal * Fix lint errors * Fix test compile * Fix unit tests - Round 1 * Avoid close-->cancel blip on successful connection * Fix unit tests - Round 2 * Fix unit tests - Round 3 * Fix unit tests - Round 4 * Removed sanitise todo, which happens in [innerHTML] * Bump go version to 1.12 in travis tests * Imporve endpoint connect step messaging * Minor text change to connect endpoint step * Add plugin info to the info call * Remove reuse component override on monocular page * Fix no margin class * Ensure we don't try to fetch sub nav items too many times * Remove console log * User Invite tweaks and helm support * Fix side nav help * Fix sidenav help overflow * Address/update todos * Address review comments * Disable demo menu action if plugin is disabled * Disable helm (see #150) * Remove unused uiFullView * Disable kube dashboard functionality via plugin config setting - plugin config - `kubeDashboardEnabled` - ensure we don't check to see if dashboard installed in kube if dashboard functionality is disabled - fix kube service ports (can be used in kube namespace servies list even without helm module) * Fix lint issues * Fix finnish as cancel & e2e tests * Fix metrics e2e test * Minor fixes * e2e fixes - Changes to reflect tabs to side and new sub header with action items * Fix locator * More specific selector * Fix merge issues * Add disabled state to file-input * Merge fixes - NOTE - help slide out does not block content underneath * Fix unit test * remove fdescribe * Fix e2e tests * Fix kube summary icon bleed & unit tests * Fixes after merge * Fixes after merge * Fix new unit test failure #1 * Fix new unit test failure #2 * Fix new unit test failure #3 * Fix new unit test failure #4 * Fix failing backend tests * Update all go references to 12.4 * Changes following merge * Changes after merge * Remove custom-src * Remove kube/helm from backend & docs * Remove backend downstream deps * cc fixes * Changes after merge
nwmac
pushed a commit
that referenced
this pull request
Apr 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.