Make sure that the registry is reachable when creating it #437
Conversation
|
A snapshot of a redirect in which we've detected that the registry is not reachable:
|
|
Would it be too hard to leave the data the user entered and change the "create" button to "force"? Other ideas:
|
|
BTW, the code looks fine to me |
Leaving the data can be a good option. I'd be against changing the "Create" button to "Force", because this way you are saying that the second attempt would effectively force the creation of the registry always, which is not the case. Maybe, as a user, you are just trying out different hostname/ssl variations, so you're not sure and don't want to force it.
+1
What about "Don't check whether it's reachable or not" ? |
Good point, let's leave the "create" button as it is.
Maybe something more compact? Like: "Skip remote checks" |
+1 |
|
@flavio I'll squash the commits before the actual merge ;) |
|
LGTM |
When creating a new registry, Portus will now check whether it's reachable or not. If it is, it will continue as usual. However, if it's not reachable, then Portus will redirect to the registries#new page and alert the user with some useful message. When this redirect happens, the user will have available an extra checkbox called "Skip remote checks". If the user checks it, then it's telling to Portus to force the creation of the registry, even if it's not reachable. Fixes SUSE#408 Signed-off-by: Miquel Sabaté Solà <[email protected]>
Make sure that the registry is reachable when creating it
When creating a new registry, Portus will now check whether it's reachable or
not. If it is, it will continue as usual. However, if it's not reachable, then
Portus will redirect to the registries#new page and alert the user with some
useful message. When this redirect happens, the user will have available an
extra checkbox called "Force". If the user checks it, then it's telling to
Portus to force the creation of the registry, even if it's not reachable.
Fixes #408
Signed-off-by: Miquel Sabaté Solà [email protected]