-
Notifications
You must be signed in to change notification settings - Fork 472
Conversation
…eam_users and team namespaces in team detail page.
Fixes #1 |
It does not work for me :/ The |
maybe |
I see. It is not generating because there is not enough data. |
@mssola I'm going to look into that this morning |
I can see the changes working. This is a summary of how pagination interacts with Portus. dashboardINDEXThe list of activities is shown there. No pagination is done here, however we already limit the number of items to 20. So I think nothing should be done. NamespacesINDEXWe have two tables here:
Proposed changeI think it's useless to pagine the special namespaces, I propose to not do that. There are going to be only 2 special namespaces as long as we do not make it possible to handle more than 1 registry. Note well: the pagination for the special repositories is also broken, but we do not care about that if we remove the feature. SHOWThere's a single table showing all the repositories that are part of a namespace. They are paginated using the default value -> 25 per page. Proposed changeNothing, everything looks good. TeamsINDEXThere's a single table showing all the teams a user is part of. The default pagination is being used -> 25 per page Proposed changeNothing, everything looks good. SHOWThe page has two tables:
Proposed changesChange paginations values that way:
admin/dashboardINDEXThe list of activities is shown there. No pagination is done here, however we already limit the number of items to 20. So I think nothing should be done. admin/activitiesINDEXThere's the list of all the activities happening on the system They are paginated using the default value -> 25 per page. Proposed changesNothing, everything looks good. admin/registriesINDEXAll the available registries are shown. No pagination is done. Proposed changesNothing, we just support one registry right now. admin/usersINDEXThe list of users is shown. We use the default value for pagination -> 25 per page Proposed changesNothing, everything is fine. admin/teamsINDEXAll the teams on portus. Default pagination value is used -> 25 per page Proposed changesNothing, everything is fine admin/namespacesINDEXTwo tables are shown:
Proposed changesDrop pagination for the special namespaces, we just support 1 global namespace ATM. |
I agree to the proposed changes |
Ok, I'll merge the PR and fix the issues straight on master |
@lsamayoa thanks a lot for your contribution! |
Fixes #135