Skip to content
This repository has been archived by the owner on Apr 17, 2023. It is now read-only.

Add pagination #232

Merged
merged 9 commits into from
Jul 27, 2015
Merged

Add pagination #232

merged 9 commits into from
Jul 27, 2015

Conversation

lsamayoa
Copy link
Contributor

Fixes #135

@lsamayoa
Copy link
Contributor Author

Fixes #1

@mssola
Copy link
Collaborator

mssola commented Jul 23, 2015

It does not work for me :/ The paginate helper method does not generate anything in the resulting HTML for me. Am I missing something ?

@lsamayoa
Copy link
Contributor Author

maybe bundle install

@lsamayoa
Copy link
Contributor Author

I see. It is not generating because there is not enough data.
It does not display anything if pagination is not needed.

@flavio
Copy link
Member

flavio commented Jul 27, 2015

@mssola I'm going to look into that this morning

@flavio
Copy link
Member

flavio commented Jul 27, 2015

I can see the changes working. This is a summary of how pagination interacts with Portus.

dashboard

INDEX

The list of activities is shown there.

No pagination is done here, however we already limit the number of items to 20. So I think nothing should be done.

Namespaces

INDEX

We have two tables here:

  • special namespaces: default pagination -> 25 per page
  • "normal" namespaces: default pagination -> 25 per page

Proposed change

I think it's useless to pagine the special namespaces, I propose to not do that. There are going to be only 2 special namespaces as long as we do not make it possible to handle more than 1 registry.

Note well: the pagination for the special repositories is also broken, but we do not care about that if we remove the feature.

SHOW

There's a single table showing all the repositories that are part of a namespace. They are paginated using the default value -> 25 per page.

Proposed change

Nothing, everything looks good.

Teams

INDEX

There's a single table showing all the teams a user is part of. The default pagination is being used -> 25 per page

Proposed change

Nothing, everything looks good.

SHOW

The page has two tables:

  • users: paginated by 5
  • namespaces: paginated by 5

Proposed changes

Change paginations values that way:

  • users: 10 per page
  • namespaces: 15 per page

admin/dashboard

INDEX

The list of activities is shown there.

No pagination is done here, however we already limit the number of items to 20. So I think nothing should be done.

admin/activities

INDEX

There's the list of all the activities happening on the system

They are paginated using the default value -> 25 per page.

Proposed changes

Nothing, everything looks good.

admin/registries

INDEX

All the available registries are shown. No pagination is done.

Proposed changes

Nothing, we just support one registry right now.

admin/users

INDEX

The list of users is shown. We use the default value for pagination -> 25 per page

Proposed changes

Nothing, everything is fine.

admin/teams

INDEX

All the teams on portus. Default pagination value is used -> 25 per page

Proposed changes

Nothing, everything is fine

admin/namespaces

INDEX

Two tables are shown:

  • special namespaces: only global namespaces are shown. Default pagination -> 25 per page
  • normal namespaces: all the other ones, including the personal ones of the users. Default pagination -> 25 per page

Proposed changes

Drop pagination for the special namespaces, we just support 1 global namespace ATM.

@flavio
Copy link
Member

flavio commented Jul 27, 2015

I have also some changes locally that switch the pagination theme from the default one:

screenshot-localhost 5000 2015-07-27 10-14-45

To one based on bootstrap3:

screenshot-localhost 5000 2015-07-27 11-06-15-bootstrap

@mssola
Copy link
Collaborator

mssola commented Jul 27, 2015

I agree to the proposed changes

@flavio
Copy link
Member

flavio commented Jul 27, 2015

Ok, I'll merge the PR and fix the issues straight on master

@flavio
Copy link
Member

flavio commented Jul 27, 2015

@lsamayoa thanks a lot for your contribution!

flavio added a commit that referenced this pull request Jul 27, 2015
@flavio flavio merged commit ad1a818 into SUSE:master Jul 27, 2015
@lsamayoa lsamayoa deleted the feature/ISSUE-135 branch July 27, 2015 18:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants