[Security] Bump nokogiri from 1.8.2 to 1.8.5

[greysteil]

Bumps nokogiri from 1.8.2 to 1.8.5. This update includes security fixes.

Vulnerabilities fixed

Sourced from The Ruby Advisory Database.

Nokogiri gem, via libxml2, is affected by multiple vulnerabilities
Nokogiri 1.8.5 has been released.

This is a security and bugfix release. It addresses two CVEs in upstream
libxml2 rated as "medium" by Red Hat, for which details are below.

If you're using your distro's system libraries, rather than Nokogiri's
vendored libraries, there's no security need to upgrade at this time,
though you may want to check with your distro whether they've patched this
(Canonical has patched Ubuntu packages). Note that these patches are not
yet (as of 2018-10-04) in an upstream release of libxml2.

Full details about the security update are available in Github Issue #1785.
[#1785]: https://github-redirect.dependabot.com/sparklemotion/nokogiri/issues/1785

---

[MRI] Pulled in upstream patches from libxml2 that address CVE-2018-14404
and CVE-2018-14567. Full details are available in #1785. Note that these
patches are not yet (as of 2018-10-04) in an upstream release of libxml2.

... (truncated)

Patched versions: >= 1.8.5
Unaffected versions: none

Sourced from The Ruby Advisory Database.

Revert libxml2 behavior in Nokogiri gem that could cause XSS
[MRI] Behavior in libxml2 has been reverted which caused
CVE-2018-8048 (loofah gem), CVE-2018-3740 (sanitize gem), and
CVE-2018-3741 (rails-html-sanitizer gem). The commit in question is
here:

GNOME/libxml2@960f0e2

and more information is available about this commit and its impact
here:

https://github-redirect.dependabot.com/flavorjones/loofah/issues/144

This release simply reverts the libxml2 commit in question to protect
users of Nokogiri's vendored libraries from similar vulnerabilities.

If you're offended by what happened here, I'd kindly ask that you
comment on the upstream bug report here:

https://bugzilla.gnome.org/show_bug.cgi?id=769760

Patched versions: >= 1.8.3
Unaffected versions: none

Changelog

Sourced from nokogiri's changelog.

1.8.5 / 2018-10-04

Security Notes

[MRI] Pulled in upstream patches from libxml2 that address CVE-2018-14404 and CVE-2018-14567. Full details are available in #1785. Note that these patches are not yet (as of 2018-10-04) in an upstream release of libxml2.

Bug fixes

• [MRI] Fix regression in installation when building against system libraries, where some systems would not be able to find libxml2 or libxslt when present. (Regression introduced in v1.8.3.) [Updated README so it's more concise #1722]
• [JRuby] Fix node reparenting when the destination doc is empty. [Updated last stable release in readme file #1773]

1.8.4 / 2018-07-03

Bug fixes

• [MRI] Fix memory leak when creating nodes with namespaces. (Introduced in v1.5.7) [portus keeps deleting and creating repos by itself #1771]

1.8.3 / 2018-06-16

Security Notes

[MRI] Behavior in libxml2 has been reverted which caused CVE-2018-8048 (loofah gem), CVE-2018-3740 (sanitize gem), and CVE-2018-3741 (rails-html-sanitizer gem). The commit in question is here:

GNOME/libxml2@960f0e2

and more information is available about this commit and its impact here:

https://github-redirect.dependabot.com/flavorjones/loofah/issues/144

This release simply reverts the libxml2 commit in question to protect users of Nokogiri's vendored libraries from similar vulnerabilities.

If you're offended by what happened here, I'd kindly ask that you comment on the upstream bug report here:

https://bugzilla.gnome.org/show_bug.cgi?id=769760

Dependencies

• [MRI] libxml2 is updated from 2.9.7 to 2.9.8

Features

• Node#classes, #add_class, #append_class, and #remove_class are added.
• NodeSet#append_class is added.
• NodeSet#remove_attribute is a new alias for NodeSet#remove_attr.
• NodeSet#each now returns an Enumerator when no block is passed (Thanks, park53kr!)

... (truncated)

Commits

• e28fa4b version bump to v1.8.5
• 712edef update changelog
• 7feb4c1 Merge branch 'fix-1773'
• 7cc6cf6 Organize imports in XmlNode.java.
• 1697442 Allow reparenting nodes to be a child of an empty document.
• 7b8cd0f Merge pull request #1786 from sparklemotion/1785-canonical-usns
• 5bff4bb pull in upstream libxml2 patches
• c232226 changelog
• 862b88f changelog
• b3750eb remove -Wextra CFLAG
• Additional commits viewable in compare view

(This is an example of the kind of PRs Dependabot creates, so you can see it in action alongside #1994. It won't automatically rebase or any of the clever stuff Dependabot normally does because I've manually copied it across, though.)

[mssola]

Thanks for the heads up 👍

[greysteil]

Thanks for the merge @mssola. Can I convince you to give Dependabot a look? Of course free for open source - I’m just trying to get more people using it as I hope it’s genuinely helpful.

[mssola]

Cherry picked into the v2.4 branch and the 2.4 Docker image already includes this fix.

Can I convince you to give Dependabot a look? Of course free for open source - I’m just trying to get more people using it as I hope it’s genuinely helpful.

I'll take a look and I'll tell you something on the other issue when I'm done 😉