Make containerized deployment more configurable

[flavio]

A bunch of changes required to be more flexible when deploying Portus into a containerized environment.

TODO

• Extend the documentation to mention the new environment variable added. (docs: updated the documentation for #1880 #1905)

[flavio]

I think this should be backported also to the 2.3 branch

[mssola]

I wouldn't delete this, since it will break the deployment for most users. I propose to export this env. variable to this default value if none has been provided.

[flavio]

This isn't going to help with my use-case: have puma bind to unix socket even when running Portus using the official container, see:

Portus/config/puma.rb

Lines 19 to 31 in 7358f3a

	if ENV["PORTUS_PUMA_HOST"]
	if ENV["PORTUS_PUMA_TLS_KEY"]
	host, port = ENV["PORTUS_PUMA_HOST"].split(":")
	port ||= "3000"
	ssl_bind host, port,
	key: ENV["PORTUS_PUMA_TLS_KEY"],
	cert: ENV["PORTUS_PUMA_TLS_CERT"]
	else
	bind "tcp://#{ENV["PORTUS_PUMA_HOST"]}"
	end
	else
	bind "unix://#{File.join(Dir.pwd, "tmp/sockets/puma.sock")}"
	end

Another way would be to rework the code I pasted above to something like:

if ENV["PORTUS_PUMA_HOST"] && !ENV["PORTUS_PUMA_USE_UNIX_SOCKET"]
...
else
# bind to socket
end

[mssola]

I'd prefer the code you just pasted instead of the old one because I believe that telling people to always set this env. variable to "0.0.0.0:3000" for the most common use case is confusing. Instead, if you really know what you are doing, you can provide this extra env. variable.

So a 👍 from my side.

[mssola]

Oh, and instead of !ENV["PORTUS_PUMA_USE_UNIX_SOCKET"], I think it's safer (and more elegant 🤓) ENV["PORTUS_PUMA_USE_UNIX_SOCKET"].blank?

[flavio]

@mssola I've updated the code but I haven't tested it. AFAIK .blank? is defined by active support, I fear this is not available at that time. Can you double check?

[flavio]

Also, which branch holds the documentation?

[mssola]

I've updated the code but I haven't tested it. AFAIK .blank? is defined by active support, I fear this is not available at that time. Can you double check?

I've tested it and nothing broke 😄 That's because we are calling puma from within the context of a Rails application (notice, for example, that we later call ActiveRecord directly 😉). So, it should be fine.

Also, which branch holds the documentation?

It's on the site-source branch, because of an issue we had with jekyll and custom plugins.

[mssola]

As for the failing integration tests, maybe a rebase does the trick, otherwise we'll have to check what's broken.

[flavio]

Rebased

[flavio]

@mssola, the patch is not working. I tested it with a containerized image and I got:

undefined method `blank?' for "true":String

I would change the patch to

if ENV["PORTUS_PUMA_HOST"] && ENV["PORTUS_PUMA_USE_UNIX_SOCKET"] != "true"

this works fine.

[mssola]

@flavio tomorrow we want to release 2.3.4, which includes an important fix. Could you update this PR so we can also include this there?

[flavio]

@mssola done!

[mssola]

Thanks 👏

[mssola]

Cherry-picked and pushed into v2.3.