Skip to content
This repository has been archived by the owner on Apr 17, 2023. It is now read-only.

Support Docker Distribution 2.5 #1068

Merged
merged 1 commit into from
Sep 29, 2016
Merged

Support Docker Distribution 2.5 #1068

merged 1 commit into from
Sep 29, 2016

Conversation

mssola
Copy link
Collaborator

@mssola mssola commented Sep 28, 2016

There were a couple of issues with supporting Docker Distribution 2.5.
Hopefully with this commit Portus can handle events coming from this
version.

I've also added more debug logging, so it's easier to check what's going
on.

Fixes #905

Signed-off-by: Miquel Sabaté Solà [email protected]

There were a couple of issues with supporting Docker Distribution 2.5.
Hopefully with this commit Portus can handle events coming from this
version.

I've also added more debug logging, so it's easier to check what's going
on.

Fixes SUSE#905

Signed-off-by: Miquel Sabaté Solà <[email protected]>
@mssola mssola merged commit 1598e83 into SUSE:master Sep 29, 2016
@mssola mssola deleted the registry-2.5 branch September 29, 2016 09:24
@toughIQ
Copy link

toughIQ commented Oct 17, 2016

I still see this webhook errors with Portus 2.1.1 and Registry 2.5.1 (same with Registry 2.4.1)
Is there a config setting I missed?
I really would like to use Registry 2.4+, since it enables deleting and works with our S3 Storage backend.
Thanks, Chris

@mssola
Copy link
Collaborator Author

mssola commented Oct 19, 2016

@toughIQ could you be more specific ? Could you provide some logs ?

@toughIQ
Copy link

toughIQ commented Oct 19, 2016

Sorry. Just found out, that I had a wrong setting in my registry config, since testing for #905.
REGISTRY_NOTIFICATIONS_ENDPOINTS: >
- name: portus
url: http://portus:3000/v2/webhooks/events
timeout: 500
threshold: 5
backoff: 2s
The timeout value needs ms appended. Without ms registry will interpret it as µs and connections would fail most of the time.

chadyred pushed a commit to chadyred/docker-image-portus that referenced this pull request Feb 1, 2017
# ADD MS TO TimeOut REGISTRY INTERPRETE pico second and made error and bug the whole portus...2.3 works great, see SUSE/Portus#905 and SUSE/Portus#1068
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants