This repository has been archived by the owner on Apr 17, 2023. It is now read-only.
portusctl: added man pages #1021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
2 tasks
|
@jordimassaguerpla @flavio @monstermunchkin @tboerger PTAL (tip: take a look at the md files not the .1 files, since they are generated from their correspondent .md files 😉 ) I'll squash my commits once the review is over. |
| ``` | ||
|
|
||
| Note that this should be done by developers. Packagers should only have to care | ||
| about the files inside of `man/man1` and disregard completely the markdown files. |
There was a problem hiding this comment.
"… and disregard the markdown files completely."
|
I've looked into the spec file and then I did a quick look at the rest. |
|
|
||
| # DESCRIPTION | ||
| **portusctl** is a tool that helps administrators to perform operation on the | ||
| installed Portus instance. For this, administrators will be able to execute |
There was a problem hiding this comment.
"… helps administrators perform operations on …"
|
Other than the comments, LGTM. |
|
I think @monstermunchkin's comments covered everything. LGTM |
Fixes SUSE#868 Signed-off-by: Miquel Sabaté Solà <[email protected]>
| ============================================================== | ||
|
|
||
| # NAME | ||
| portusctl logs \- Fetch all the logs produced by Portus |
There was a problem hiding this comment.
It's portusctl exec and not logs markdown file.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #868
Signed-off-by: Miquel Sabaté Solà [email protected]