Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed conflicting background styles on checkboxes #644

Merged
merged 1 commit into from
Apr 14, 2020

Conversation

pookmish
Copy link
Contributor

@pookmish pookmish commented Apr 1, 2020

READY FOR REVIEW

Summary

  • Checkboxes display an empty white area. this allows the check image to be used instead.

Needed By (Date)

  • 🤷‍♂️

Urgency

  • Medium

Steps to Test

  1. review checkbox styles checked and unchecked.

Affected Projects or Products

  • Does this PR impact any particular projects, products, or modules?

Associated Issues and/or People

  • JIRA ticket
  • Other PRs
  • Any other contextual information that might be helpful (e.g., description of a bug that this PR fixes, new functionality that it adds, etc.)
  • Anyone who should be notified? (@mention them here)

See Also

@pookmish pookmish requested a review from sherakama April 1, 2020 21:10
@sherakama sherakama linked an issue Apr 2, 2020 that may be closed by this pull request
@@ -64,7 +64,6 @@

[type='checkbox']:checked + label::before,
[type='checkbox']:checked:disabled + label::before {
background: url("#{$su-image-path}/check.png");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure this is a fallback technique for browsers that don't support SVG backgrounds. Let me check on this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks widely supported https://caniuse.com/#feat=svg-css

@sherakama sherakama merged commit 1f96cea into master Apr 14, 2020
@sherakama sherakama deleted the pookmish-patch-1 branch April 14, 2020 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants