Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecated '@elseif' syntax #600

Merged
merged 1 commit into from
Dec 20, 2019
Merged

Conversation

nrambeck
Copy link

@nrambeck nrambeck commented Dec 20, 2019

READY FOR REVIEW

Summary

Fixes a few instances in Sass of @elseif syntax and replaces it with the support @else if syntax. Newer versions of Sass have deprecated the @elseif syntax and it will be dropped in future versions.

Needed By (Date)

No specific date

Urgency

Nothing is broken now. For those using the latest version of Sass, there are deprecation warning in every build which can cause lots of noise and make it hards to see other errors. The old syntax will probably continue to be supported for 6 months to a year or more.

Steps to Test

  1. Compile Decanter (before this commit) with the latest version of Dart Sass
  2. You should see deprecation warnings
  3. Compile this PR with the latest version of Dart Sass
  4. The deprecation warnings should no longer be generated

Affected Projects or Products

The H&S Drupal 8 project is currently getting these deprecation errors with new themes that are currently in development. This is because we are using the latest version of Dart Sass.

Associated Issues and/or People

Accessibility Checks

  • None, N/A

See Also

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…ntax

Resolves SU-SWS#598
@sherakama sherakama temporarily deployed to Tugboat December 20, 2019 17:52 Destroyed
Copy link
Member

@sherakama sherakama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GTG

@sherakama sherakama merged commit 43d2cd3 into SU-SWS:master Dec 20, 2019
@cjwest
Copy link
Member

cjwest commented Dec 20, 2019

Thank you, @nrambeck !

@nrambeck nrambeck deleted the deprecated-elseif branch December 20, 2019 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants