New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove max-width on `flex-container` #535

Merged

sherakama merged 2 commits into master from flex-container-rm

Nov 9, 2019

Member

sherakama commented Nov 8, 2019

READY FOR REVIEW

Summary

No need to max-width a container as we have other mixins and styles for limiting and positioning.

Feedback:

I was expecting flex-container to be full-width flex. and then I would add the centered-container to set max-width.

Needed By (Date)

Whenever

Urgency

Low

Steps to Test

Review code changes
Review tugboat preview

Associated Issues and/or People

@pookmish

See Also

PR Checklist


          Remove max-width on flex-container

f353e55

No need to max-width a container.

sherakama requested a review from yvonnetangsu

November 8, 2019 19:25

sherakama assigned yvonnetangsu

sherakama temporarily deployed to Tugboat

November 8, 2019 19:25

Destroyed


          compile

b0ad074

sherakama temporarily deployed to Tugboat

November 8, 2019 19:31

Destroyed

yvonnetangsu approved these changes

View reviewed changes

Member

yvonnetangsu left a comment

Sounds fine to me. GTG!

sherakama merged commit d3f63b5 into master

sherakama deleted the flex-container-rm branch

November 9, 2019 00:33

Member Author

sherakama commented Nov 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet