add favicon to style guide #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JBCSU
reviewed
Apr 1, 2019
|
CC: @kerri-augenstein (FYI that this is being worked on). |
|
Testing @josephgknox. |
JBCSU
approved these changes
Apr 2, 2019
sherakama
approved these changes
Apr 4, 2019
yvonnetangsu
added a commit
that referenced
this pull request
Jun 11, 2019
* master: (44 commits) Set up color maps for Decanter and refactor main nav colors to refer to color maps (#420) Move PR template (#416) Fix skiplink target so it doesn't take up space and cause overflow (#415) Release 5.0.1 (#417) Fix CSS grid gaps not displaying on Edge issue and other minor grid related issues (#413) More link fixup (#388) forgot to rebuild .js after final lint fixes (#387) add openNav, closeNav, openSubnav, closeSubnav events (#379) Fix main nav color variants and work with new linting rules (#380) add favicon to style guide (#377) Adjust linters. (#370) update readme.md to match Scott's intro on homepage.md (#371) Update README.md (#369) move the images we need for the styleguide's homepage into kss-assets (#368) Update README.md (#367) Update UPGRADE.md (#363) package.locl.json file is back (#366) Added more to changelog (#364) Update homepage.md (#362) 90 basic webpack (#334) ... # Conflicts: # core/scss/components/index.scss
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
READY FOR REVIEW
Summary
Needed By (Date)
Urgency
Steps to Test
npm run styleguideAffected Projects or Products
Associated Issues and/or People
See Also